<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28478">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162149">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file_unix.cpp:286</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint16_t</span> <span style="color: #004012">stat_mode</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">stx_mode</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint32_t</span> <span style="color: #004012">stat_dev</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">stx_dev_major</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint32_t</span> <span style="color: #004012">stat_dev</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">buf</span><span class="p">.</span><span class="n">stx_dev_maj<span class="bright">or</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">100</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">buf</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">stx_dev_min</span>or</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint64_t</span> <span style="color: #004012">stat_ino</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">stx_ino</span><span class="p">;</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;"> * 100</tt> is definitely wrong - maybe <tt style="background: #ebebeb; font-size: 13px;">* 0x100</tt>, but ...</p>
<p style="padding: 0; margin: 8px;">TLDR: use <tt style="background: #ebebeb; font-size: 13px;">makedev</tt>, and change the return type to dev_t.</p>
<p style="padding: 0; margin: 8px;">dev_t is defined as a 64bit type atleast on Linux, which matches the 32bit major/minor parts of buf.stx_dev_*. Traditionally, major/minor are used as low/high bytes of a 16 bit type, but these can easily exhausted on a larger system. So this is was makedev does:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#define __SYSMACROS_DEFINE_MAKEDEV(DECL_TEMPL) \
__SYSMACROS_DECLARE_MAKEDEV (DECL_TEMPL) \
{ \
__dev_t __dev; \
__dev = (((__dev_t) (__major & 0x00000fffu)) << 8); \
__dev |= (((__dev_t) (__major & 0xfffff000u)) << 32); \
__dev |= (((__dev_t) (__minor & 0x000000ffu)) << 0); \
__dev |= (((__dev_t) (__minor & 0xffffff00u)) << 12); \
return __dev; \
}</pre></div>
</div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28478">https://phabricator.kde.org/D28478</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, meven<br /><strong>Cc: </strong>bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham<br /></div>