<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27951">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27951#637792" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27951#637792</a>, <a href="https://phabricator.kde.org/p/trmdi/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@trmdi</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27951#637690" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27951#637690</a>, <a href="https://phabricator.kde.org/p/meven/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@meven</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Look into kde connect kioslave.<br />
That does not concern this diff much though.</p></div>
</blockquote>
<p>I don't understand this. I'm using KMountPoint to check if source and dest are on the same partion, it's working as expected.<br />
But if I switch to use <tt style="background: #ebebeb; font-size: 13px;">KIO::StatJob</tt>, it will fail, because for the file inside a KDE Connect directory, <tt style="background: #ebebeb; font-size: 13px;">KIO::UDSEntry::UDS_DEVICE_ID</tt> return the same value with the root partion.</p></div>
</blockquote>
<p>Maybe you don't much about KIO.</p>
<p>Anything that uses <tt style="background: #ebebeb; font-size: 13px;">KIO::</tt> calls is treated by ioslave which are programs to handle protocols.<br />
For instance file:/ (that handles /) or kdeconnect:/<br />
Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in <tt style="background: #ebebeb; font-size: 13px;">KIO::StatJob</tt>.<br />
It is in the kdeconnect code base, the issue you point to is there.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Another question, will UDSEntry::UDS_DEVICE_ID be available on Windows?</p></blockquote>
<p>I am not a Windows specialist but I imagine we could hack together an equivalent solution (I am saying this should be possible not that we will implement, feel free to give it a try in file_win.cpp ;) ).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27951#inline-162114">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dropjob.cpp:309</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">sourceDevice</span> <span style="color: #aa2211">=</span> <span class="n">mountPoints</span><span class="p">.</span><span class="n">findByPath</span><span class="p">(</span><span class="n">url</span><span class="p">.</span><span class="n">path</span><span class="p">())</span><span style="color: #aa2211">-></span><span class="n">mountedFrom</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">sourceDevice</span> <span style="color: #aa2211">!=</span> <span class="n">destDevice</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">KFileItem</span><span class="p">(</span><span class="n">url</span><span class="p">).</span><span class="n">isLink</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">allItemsAreSameDevice</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can create a <tt style="background: #ebebeb; font-size: 13px;">KFileItem(url)</tt> before, so that you can reuse it line 314, instead of building one again.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27951">https://phabricator.kde.org/D27951</a></div></div><br /><div><strong>To: </strong>trmdi, ngraham, dfaure, meven, VDG, davidedmundson<br /><strong>Cc: </strong>elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>