<table><tr><td style="">meven added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28478">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162091">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1382</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span style="color: #004012">url</span><span class="p">(</span><span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">filePath</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StatJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">stat</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">HideProgressInfo</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StatJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">stat<span class="bright">Details</span></span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">StatJob</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">SourceSide</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">KIO</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">StatDefaultDetails</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">|</span></span><span class="bright"> </span><span class="n"><span class="bright">KIO</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">StatInode</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">job</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add a separate test dedicated for Inode like <tt style="background: #ebebeb; font-size: 13px;">statWithInode()</tt> like <tt style="background: #ebebeb; font-size: 13px;">statSymlink</tt> does for instance.<br />
Here you change the purpose of this test : default stat behavior with stat(), to default + inode with statDetails.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162092">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1398</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">    </span><span class="n"><span class="bright">QCOMPARE</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">entry</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">count</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">8</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">entry</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">contains</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">KIO</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">UDSEntry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">UDS_CREATION_TIME</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">#if 1 </span></span><span class="bright"></span><span style="color: #74777d"><span class="bright">// should be HAVE_STATX</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_CREATION_TIME</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_DEVICE_ID</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">UDS_CREATION_TIME is statx specific only on Linux<br />
Just make it clear in the comment.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162093">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1400</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_DEVICE_ID</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_INODE</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">count</span><span class="p">(),</span> <span style="color: #601200">11</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KIO::UDSEntry::UDS_DEVICE_ID and KIO::UDSEntry::UDS_INODE are not statx specific (it is supported for all UNIX systems)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162095">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file_unix.cpp:286</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint16_t</span> <span style="color: #004012">stat_mode</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">stx_mode</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint32_t</span> <span style="color: #004012">stat_dev</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">stx_dev_major</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint32_t</span> <span style="color: #004012">stat_dev</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">buf</span><span class="p">.</span><span class="n">stx_dev_maj<span class="bright">or</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">100</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">buf</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">stx_dev_min</span>or</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">uint64_t</span> <span style="color: #004012">stat_ino</span><span class="p">(</span><span style="color: #aa4000">struct</span> <span class="n">statx</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">stx_ino</span><span class="p">;</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We should probably use <tt style="background: #ebebeb; font-size: 13px;">makedev</tt> <a href="http://man7.org/linux/man-pages/man3/makedev.3.html" class="remarkup-link" target="_blank" rel="noreferrer">http://man7.org/linux/man-pages/man3/makedev.3.html</a> in fact to ensure to match original stat behavior.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162090">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file_unix.cpp:304</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">mode_t</span> <span style="color: #004012">stat_mode</span><span class="p">(</span><span class="n">QT_STATBUF</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">st_mode</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">dev_t</span> <span style="color: #004012">stat_dev</span><span class="p">(</span><span class="n">QT_STATBUF</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">st_dev</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">inline</span> <span style="color: #aa4000">static</span> <span style="color: #aa4000">ino_t</span> <span style="color: #004012">stat_ino</span><span class="p">(</span><span class="n">QT_STATBUF</span> <span style="color: #aa2211">&</span><span class="n">buf</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">buf</span><span class="p">.</span><span class="n">st_ino</span><span class="p">;</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you compare with the no-statx case ?<br />
We should try to have the same output.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28478">https://phabricator.kde.org/D28478</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, meven<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>