<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27540">View Revision</a></tr></table><br /><div><div><p>What do we want to happen for released code that gets a bugfix update?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27540#inline-161969">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kconfigdialogmanager.cpp:609</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">defaultValue</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span class="n">item</span><span class="p">]</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">swapDefault</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">value</span> <span style="color: #aa2211">=</span> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not item->readDefault()?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27540#inline-161970">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kconfigdialogmanager.cpp:625</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span class="n">widget</span><span class="p">,</span> <span class="n">defaultValue</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">updateWidgetIndicator</span><span class="p">(</span><span class="n">configId</span><span class="p">,</span> <span class="n">widget</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">widgetModified</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">won't it do it itself when the property changes?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27540#inline-161975">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingsstatusindicator.cpp:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setFocusPolicy</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">NoFocus</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">show</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">This is equivalent to calling showFullScreen(), showMaximized(), or setVisible(true), depending on the platform's default behavior for the window flags.</p></blockquote>
<p style="padding: 0; margin: 8px;">For X and wayland it's setVisible(true)</p>
<p style="padding: 0; margin: 8px;">but we shouldn't count on it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27540#inline-161979">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingsstatusindicator.cpp:175</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">leftToRight</span> <span style="color: #aa2211">=</span> <span class="n">m_trackedWidget</span><span style="color: #aa2211">-></span><span class="n">isLeftToRight</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="n">leftToRight</span> <span style="color: #aa2211">?</span> <span class="n">m_trackedWidget</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">m_trackedWidget</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">:</span> <span class="n">m_trackedWidget</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">width</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unused?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27540#inline-161977">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingsstatusindicator.cpp:184</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">re</span> <span style="color: #aa2211">=</span> <span class="n">QRegularExpression</span><span class="p">(</span><span style="color: #766510">"^kcfg_"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">children</span> <span style="color: #aa2211">=</span> <span class="n">m_trackedWidget</span><span style="color: #aa2211">-></span><span class="n">parentWidget</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">findChildren</span><span style="color: #aa2211"><</span><span class="n">QWidget</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">re</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">FindDirectChildrenOnly</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">xValues</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">]</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can we be sure the tracked widget always has a parent widget?</p>
<p style="padding: 0; margin: 8px;">If someone doesn't use layouts a widget might not have a parent.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27540#inline-161981">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingsstatusindicator.cpp:192</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">localX</span> <span style="color: #aa2211">=</span> <span class="n">leftToRight</span> <span style="color: #aa2211">?</span> <span class="n">widgetExpectedWidth</span><span class="p">(</span><span class="n">w</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #aa2211">-</span><span class="n">width</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">w</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">localX</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">that's not true for the RTL case where the widget is expected to resize.</p>
<p style="padding: 0; margin: 8px;">It would be w->pos().x() + w->width() - widgetExpectedWidth(w)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27540">https://phabricator.kde.org/D27540</a></div></div><br /><div><strong>To: </strong>ervin, ngraham, davidedmundson, meven, crossi, bport, VDG, ndavis, broulik<br /><strong>Cc: </strong>alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>