<table><tr><td style="">apol created this revision.<br />apol added reviewers: Frameworks, KWin.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />apol requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28442">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Remove unused variables and members.<br />
We were often storing the q of classes without ever needing them. I'd<br />
just do it when it's useful. We do it in the private class so it can<br />
always be added, removes boilerplate code.</p>

<p>Don't use std::move when returning temporary QImage. The compiler is<br />
smart enough to know to do it but produces the warning "moving a<br />
temporary object prevents copy elision".</p>

<p>Remove unused lambda captured variables.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Getting much cleaner build logs</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28442">https://phabricator.kde.org/D28442</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/client/test_shm_pool.cpp<br />
autotests/client/test_wayland_outputmanagement.cpp<br />
autotests/client/test_wayland_shell.cpp<br />
src/client/appmenu.cpp<br />
src/client/event_queue.cpp<br />
src/client/idleinhibit.cpp<br />
src/client/server_decoration_palette.cpp<br />
src/server/buffer_interface.cpp<br />
src/server/display.cpp<br />
src/server/eglstream_controller_interface.cpp<br />
src/server/fakeinput_interface.cpp<br />
src/server/output_interface.cpp<br />
src/server/plasmavirtualdesktop_interface.cpp<br />
src/server/plasmawindowmanagement_interface.cpp<br />
src/server/textinput_interface_v0.cpp<br />
tests/shadowtest.cpp<br />
tests/touchclienttest.cpp<br />
tests/xdgforeigntest.cpp</div></div></div><br /><div><strong>To: </strong>apol, Frameworks, KWin<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>