<table><tr><td style="">davidhurka requested review of this revision.<br />davidhurka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28203">View Revision</a></tr></table><br /><div><div><p>One potentially important thing: See inline comment.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28203#inline-161441">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filename-title-amarok.svg:8</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            }
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">      .ColorScheme-<span class="bright">Highlight</span> {
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span class="bright">      </span>.ColorScheme-<span class="bright">ButtonFocus</span> {
</div><div style="padding: 0 8px; margin: 0 4px; ">                color:#3daee9;
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I realized that <a href="http://notmart.org/blog/2016/05/icon-colors/" class="remarkup-link" target="_blank" rel="noreferrer">http://notmart.org/blog/2016/05/icon-colors/</a> and <a href="https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets</a> contratict in the class names. One uses <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-Highlight</tt>, the other <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-ButtonFocus</tt>. breeze-icon-cleaner uses <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-ButtonFocus</tt>. In the repository I see several icons which use <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-Highlight</tt>, and only a few which use <tt style="background: #ebebeb; font-size: 13px;">ColorScheme-ButtonFocus</tt>.</p>

<p style="padding: 0; margin: 8px;">So which one is correct? I assume that <a href="https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets</a> needs to be fixed.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28203">https://phabricator.kde.org/D28203</a></div></div><br /><div><strong>To: </strong>davidhurka, VDG, ndavis, ngraham<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns<br /></div>