<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28325">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28325#inline-161187">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kinotify.cpp:368</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">uint32_t</span> <span class="n">fileEvents</span> <span style="color: #aa2211">=</span> <span class="n">EventAll</span> <span style="color: #aa2211">&</span> <span style="color: #aa2211">~</span><span class="p">(</span><span class="n">EventMoveFrom</span> <span style="color: #aa2211">|</span> <span class="n">EventQueueOverflow</span> <span style="color: #aa2211">|</span> <span class="n">EventIgnored</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">fname</span> <span style="color: #aa2211">=</span> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">mask</span> <span style="color: #aa2211">&</span> <span class="n">fileEvents</span> <span style="color: #aa2211">?</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">decodeName</span><span class="p">(</span><span class="n">path</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">QString</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For better code readabillity a bit-operator-based condition is often put into brackets:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QString fname = (event->mask & fileEvents) ? QFile::decodeName(path) : QString();</pre></div>

<p style="padding: 0; margin: 8px;">You might want to do this here as well.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28325">https://phabricator.kde.org/D28325</a></div></div><br /><div><strong>To: </strong>bruns, Baloo, ngraham<br /><strong>Cc: </strong>kossebau, apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>