<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27840">View Revision</a></tr></table><br /><div><div><p>Cool</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161115">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateBinding.qml:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * target: Item</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * The graphical element which state we want to manage based on a setting</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">*whose</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161124">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateBinding.qml:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * extraEnabledPredicate: bool</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * An extra predicate which will be applied to the enabled property</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * of the target combined with the immutable state of the setting</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This description didn't really help me in understanding what it does until I read the code further down.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161120">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateBinding.qml:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">KCM</span><span class="p">.</span><span style="color: #004012">SettingStateIndicator</span> <span style="color: #aa4000">indicator:</span> <span style="color: #000a65">null</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Necessary for proper binding within the Component element,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// otherwise it would get null for its created instances</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you explain this.<br />
Can't you</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">indicatorComponent.createObject(target, {
settingsState: settingsState
});</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161121">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateBinding.qml:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// We use it via a Component because we potentially need</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// to escape the parent/siblings only constraint for anchoring</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We could also bind <tt style="background: #ebebeb; font-size: 13px;">parent: target</tt> instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161122">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateBinding.qml:97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">KCM</span><span class="p">.</span><span style="color: #004012">SettingStateIndicator</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">x:</span> <span style="color: #004012">helper</span><span class="p">.</span><span style="color: #004012">leftCoord</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">indicatorAsOverlay</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">width :</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">y:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">indicatorAsOverlay</span> <span style="color: #aa2211">?</span> <span style="color: #601200">0</span> <span style="color: #aa2211">:</span> <span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #004012">height</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please check if this works with right-to-left languages (run with <tt style="background: #ebebeb; font-size: 13px;">-reverse</tt> argument to test)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161123">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateBinding.qml:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">x:</span> <span style="color: #004012">helper</span><span class="p">.</span><span style="color: #004012">leftCoord</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">indicatorAsOverlay</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">width :</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">y:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">indicatorAsOverlay</span> <span style="color: #aa2211">?</span> <span style="color: #601200">0</span> <span style="color: #aa2211">:</span> <span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #004012">height</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">settingState:</span> <span style="color: #004012">impl</span><span class="p">.</span><span style="color: #004012">settingState</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Always <tt style="background: #ebebeb; font-size: 13px;">Math.round</tt> whenever you divide sizes to ensure integer alignment</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161126">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateIndicator.qml:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #601200">16</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: #601200">16</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Probably should be <tt style="background: #ebebeb; font-size: 13px;">Kirigami.Units.iconSizes.small</tt>.<br />
Generally, when creating reusable components, avoid giving them a <tt style="background: #ebebeb; font-size: 13px;">width</tt> and <tt style="background: #ebebeb; font-size: 13px;">height</tt>.<br />
Instead, define an <tt style="background: #ebebeb; font-size: 13px;">implicitWidth</tt> and <tt style="background: #ebebeb; font-size: 13px;">implicitHeight</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161128">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateIndicator.qml:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: #601200">16</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">icon</span><span class="p">.</span><span style="color: #004012">source</span> <span style="color: #aa2211">!==</span> <span style="color: #766510">""</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Perhaps bind to <tt style="background: #ebebeb; font-size: 13px;">icon.valid</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161129">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingStateIndicator.qml:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">MouseArea</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.fill:</span> <span style="color: #004012">parent</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You could make the <tt style="background: #ebebeb; font-size: 13px;">root</tt> <tt style="background: #ebebeb; font-size: 13px;">Item</tt> a <tt style="background: #ebebeb; font-size: 13px;">MouseArea</tt> instead.<br />
Also, I think this should get some kind of hover and/or pressed indication?<br />
Also, what about <tt style="background: #ebebeb; font-size: 13px;">Accessible</tt> and keyboard focus? Should this be a proper <tt style="background: #ebebeb; font-size: 13px;">ToolButton</tt> control instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161131">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingstatebindingprivate.cpp:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Split since some exported types will be of the form: Foo_QMLTYPE_XX</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">className</span> <span style="color: #aa2211">=</span> <span class="n">QByteArray</span><span class="p">(</span><span class="n">item</span><span style="color: #aa2211">-></span><span class="n">metaObject</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">className</span><span class="p">()).</span><span class="n">split</span><span class="p">(</span><span style="color: #766510">'_'</span><span class="p">).</span><span class="n">first</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Odd. Wouldn't we just get <tt style="background: #ebebeb; font-size: 13px;">QQuickRowLayout</tt> et al? Or is that if you do a custom item with a <tt style="background: #ebebeb; font-size: 13px;">Layout</tt> as a base?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161134">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingstatebindingprivate.cpp:82</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_target</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span class="n">bindingProperty</span><span class="p">,</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">fromValue</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_target</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QQuickItem</span><span style="color: #aa2211">::</span><span class="n">parentChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SettingStateBindingPrivate</span><span style="color: #aa2211">::</span><span class="n">triggerCoordChanges</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_target</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QQuickItem</span><span style="color: #aa2211">::</span><span class="n">widthChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SettingStateBindingPrivate</span><span style="color: #aa2211">::</span><span class="n">triggerCoordChanges</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Too bad <tt style="background: #ebebeb; font-size: 13px;">QQuickItemChangeListener</tt> is private.</p>
<p style="padding: 0; margin: 8px;">Also, does any of this need event compression?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161135">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingstatebindingprivate.cpp:90</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">targetChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">leftCoordChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Check if it actually changed before emitting</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161136">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingstatebindingprivate.cpp:107</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">indicatorChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">leftCoordChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Check if it actually changed before emitting</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27840#inline-161130">View Inline</a><span style="color: #4b4d51; font-weight: bold;">settingstatebindingprivate.h:29</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_OBJECT</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">QQuickItem</span><span style="color: #aa2211">*</span> <span class="n">target</span> <span class="n">READ</span> <span class="n">target</span> <span class="n">WRITE</span> <span class="n">setTarget</span> <span class="n">NOTIFY</span> <span class="n">targetChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">QQuickItem</span><span style="color: #aa2211">*</span> <span class="n">indicator</span> <span class="n">READ</span> <span class="n">indicator</span> <span class="n">WRITE</span> <span class="n">setIndicator</span> <span class="n">NOTIFY</span> <span class="n">indicatorChanged</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style, <tt style="background: #ebebeb; font-size: 13px;">QQuickItem *target</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27840">https://phabricator.kde.org/D27840</a></div></div><br /><div><strong>To: </strong>ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, Frameworks, Plasma<br /><strong>Cc: </strong>broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>