<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27338">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27338#inline-160923">View Inline</a><span style="color: #4b4d51; font-weight: bold;">inputmethod_interface.cpp:128-129</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">wl_resource_destroy</span><span class="p">(</span><span class="n">resource</span><span style="color: #aa2211">-></span><span class="n">handle</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">resourceMap</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">deleteLater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Destroy <tt style="background: #ebebeb; font-size: 13px;">q</tt> in zwp_input_method_context_v1_destroy_resource(). In the destructor request, we usually want to destroy only the resource.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27338#inline-160924">View Inline</a><span style="color: #4b4d51; font-weight: bold;">inputmethod_interface.cpp:181</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">class</span> <span style="color: #00702a">Q_DECL_HIDDEN</span> <span class="n">InputPanelSurfaceInterface</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Private</span> <span class="p">:</span> <span style="color: #aa4000">public</span> <span class="n">QtWaylandServer</span><span style="color: #aa2211">::</span><span class="n">zwp_input_panel_surface_v1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We need to destroy the wl_resource for zwp_input_panel_surface_v1 when the associated surface is destroyed.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27338#inline-160911">View Inline</a><span style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: #4b4d51; font-weight: bold;">inputmethod_interface.cpp:179</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I don't know, just looked at it and it doesn't seem that useful?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">zwp_input_panel_surface_v1 defines a surface role (based on weston code) so it should be a subclass of SurfaceRole. In long term, we want to do something like</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">SurfaceRole</span> <span style="color: #aa2211">*</span><span class="n">role</span> <span style="color: #aa2211">=</span> <span class="n">SurfaceRole</span><span style="color: #aa2211">::</span><span class="n">get</span><span class="p">(</span><span class="n">surface</span><span class="p">);</span>
<span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">role</span><span class="p">)</span> <span class="p">{</span>
<span class="n">wl_resource_post_error</span><span class="p">(</span><span class="n">resource</span><span style="color: #aa2211">-></span><span class="n">handle</span><span class="p">,</span> <span class="n">ZMY_SHELL_SURFACE_ERROR_ROLE</span><span class="p">,</span>
<span style="color: #766510">"Cannot reassign surface role"</span><span class="p">);</span> <span style="color: #74777d">// DIE!</span>
<span style="color: #aa4000">return</span><span class="p">;</span>
<span class="p">}</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27338#inline-160912">View Inline</a><span style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: #4b4d51; font-weight: bold;">inputmethod_interface.cpp:199-200</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I would rather not, otherwise when implementing private members they read like local variables.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Frameworks' policies have no a single word about this so I guess it's okay(?) to put <tt style="background: #ebebeb; font-size: 13px;">m_</tt>. I asked to drop <tt style="background: #ebebeb; font-size: 13px;">m_</tt> because Qt folks seem to prefer not to put <tt style="background: #ebebeb; font-size: 13px;">m_</tt> in private classes.</p>
<p style="padding: 0; margin: 8px;">I would appreciate if you bring this topic up to the discussion in #kde-frameworks-devel since we're not consistent with naming in private classes.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27338">https://phabricator.kde.org/D27338</a></div></div><br /><div><strong>To: </strong>apol, KWin, Frameworks<br /><strong>Cc: </strong>zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>