<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28161">View Revision</a></tr></table><br /><div><div><p>Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((</p>
<p>Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> <a href="https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client" class="remarkup-link" target="_blank" rel="noreferrer">https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28161">https://phabricator.kde.org/D28161</a></div></div><br /><div><strong>To: </strong>ahmadsamir, dfaure, sitter, apol<br /><strong>Cc: </strong>kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov<br /></div>