<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: apol, davidedmundson, nicolasfella, vkrause, broulik.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28201">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Ported runCommand to CommandLauncherJob</li>
<li class="remarkup-list-item">Added a unittest</li>
</ul>

<p>I'll try to port all users away from runCommand before deprecating<br />
it, once apps can depend on KF 5.69.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Test passes. I'll now test the code where dolphin start kompare<br />
usin runCommand.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>2020_03_commandlauncherjob</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28201">https://phabricator.kde.org/D28201</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />
autotests/commandlauncherjobtest.cpp<br />
autotests/commandlauncherjobtest.h<br />
src/gui/CMakeLists.txt<br />
src/gui/commandlauncherjob.cpp<br />
src/gui/commandlauncherjob.h<br />
src/widgets/krun.cpp</div></div></div><br /><div><strong>To: </strong>dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>