<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27951">View Revision</a></tr></table><br /><div><div><p>I've done a code review, they need following up regardless.</p>
<hr class="remarkup-hr" />
<p>As you saw in the bug report I don't like the feature, and I'm against it. Though I can't veto changes.</p>
<p>Repeating myself on bugzilla.</p>
<p>The two things I really hate as justifications for doing anything are "windows does it" or "many users want". It's our job to do thinking and provide something that's actually better.</p>
<p>This little menu was one of the first things I saw when I first used Konqueror and I remember it being one of the things that made me love KDE. <br />
It's excellent thought through usability, drag and drop is inherently ambiguous. For something so important, always prompting is always safe. It's consistent and not pseudo-random and the little UI follows fitt's law and is scarcely slower. I'm aware this is an option, but IMHO an option for something bad.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27951#inline-160199">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dropjob.cpp:366</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// if the default behavior has been changed to MoveAction</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">KConfigGroup</span> <span class="n">g</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kdeglobals"</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"KDE"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">g</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"dndToMove"</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">there's no need to reopen kdelgobals</p>
<p style="padding: 0; margin: 8px;">Use KSharedConfig::openConfig()</p>
<p style="padding: 0; margin: 8px;">and due to the magic of cascading it will include kdeglobals</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27951#inline-158440">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dropjob.cpp:286</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStorageInfo</span> <span class="n">sourceStorage</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStorageInfo</span> <span style="color: #004012">destStorage</span><span class="p">(</span><span class="n">m_destUrl</span><span class="p">.</span><span class="n">path</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why QStorageInfo? We're in kio. There's a KMountPoint which is similar</p>
<p style="padding: 0; margin: 8px;">I suspect this is a recursive list up the tree resolving symlinks. This will mean blocking stat calls, so this somewhat undermines a lot of the recent work in that field.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27951#inline-158439">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dropjob.cpp:287</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStorageInfo</span> <span class="n">sourceStorage</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStorageInfo</span> <span style="color: #004012">destStorage</span><span class="p">(</span><span class="n">m_destUrl</span><span class="p">.</span><span class="n">path</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If destination is a symlink on the same partition but that symlink points to another partition what happens?</p>
<p style="padding: 0; margin: 8px;">I haven't checked myself, but if we are doing this I need us to be super super sure.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27951#inline-158450">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dropjob.cpp:309</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sourceStorage</span><span class="p">.</span><span class="n">setPath</span><span class="p">(</span><span class="n">url</span><span class="p">.</span><span class="n">path</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">sourceStorage</span><span class="p">.</span><span class="n">device</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">destStorage</span><span class="p">.</span><span class="n">device</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">allItemsAreSameDevice</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This will trigger when both storage devices are invalid, which isn't what we want.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27951">https://phabricator.kde.org/D27951</a></div></div><br /><div><strong>To: </strong>trmdi, ngraham, dfaure, meven, VDG, davidedmundson<br /><strong>Cc: </strong>elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>