<table><tr><td style="">ngraham added reviewers: VDG, davidedmundson.<br />ngraham accepted this revision.<br />ngraham added a subscriber: davidedmundson.<br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27951">View Revision</a></tr></table><br /><div><div><p>Fantastic.</p>
<p>I'm approving this since my concerns have been resolved and it works as you've indended it, but don't land it as it needs more discussion first. I know that <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> had concerns about this. Let's make sure everyone is included in the discussion.</p>
<p>To be complete, we'll need companion patches to fix the cursor for various use cases (dolphin <-> dolphin, dolphin -> Folder View) and add a config UI for this in the Workspace Behavior KCM. Something like this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Drag and drop files: (o) Always ask what to do
( ) Move files if location is on the same disk</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27951#inline-158383">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dropjob.cpp:371</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">KConfigGroup</span> <span class="n">g</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kdeglobals"</span><span class="p">)),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"KDE"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">g</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"dndToMove"</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">m_possibleActions</span> <span style="color: #aa2211">&</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">MoveAction</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_dropAction</span> <span style="color: #aa2211">=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">MoveAction</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe we should call it something more descriptive, like "dndMoveByDefault"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27951">https://phabricator.kde.org/D27951</a></div></div><br /><div><strong>To: </strong>trmdi, ngraham, dfaure, meven, VDG, davidedmundson<br /><strong>Cc: </strong>davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>