<table><tr><td style="">ervin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27840">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27840#622937" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D27840#622937</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This patch doesn't apply on top of KDeclarative for me:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">    This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (a1282da765c1b909d03d6c94eb77fd99e4374d74)
    [Y/n] y

Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.h...
Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp...
Checking patch src/qmlcontrols/kcmcontrols/qml/qmldir...
Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml...
Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml...
Checking patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp...
Checking patch src/qmlcontrols/kcmcontrols/CMakeLists.txt...
error: while searching for:

set(kcmcontrols_SRCS
    kcmcontrolsplugin.cpp
)

add_library(kcmcontrolsplugin SHARED ${kcmcontrols_SRCS})

error: patch failed: src/qmlcontrols/kcmcontrols/CMakeLists.txt:2
Hunk #2 succeeded at 12 (offset -1 lines).
Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.h cleanly.
Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/qmldir cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml cleanly.
Applied patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp cleanly.
Applying patch src/qmlcontrols/kcmcontrols/CMakeLists.txt with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.

 Patch Failed!</pre></div></div>
</blockquote>

<p>Ah right, sorry it depends on <a href="https://phabricator.kde.org/D27839" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D27839</a>.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27840">https://phabricator.kde.org/D27840</a></div></div><br /><div><strong>To: </strong>ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, Frameworks, Plasma<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>