<table><tr><td style="">niccolove added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27695">View Revision</a></tr></table><br /><div><div><p>Two questions:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">I know we should not assume it's a Layout, but margins should be defined inside the file as they compensate the inset; is it possible to both define them with Layout and anchors, or something that would work with both?</li>
<li class="remarkup-list-item">Is code on line 51 fine? Lines are a bit long there</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27695">https://phabricator.kde.org/D27695</a></div></div><br /><div><strong>To: </strong>niccolove, mart<br /><strong>Cc: </strong>davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>