<table><tr><td style="">sitter created this revision.<br />sitter added a reviewer: ngraham.<br />Herald added projects: Dolphin, Frameworks.<br />Herald added subscribers: kfm-devel, kde-frameworks-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27800">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>this allows us to use the intermediate static target for unit testing<br />
(which we'll want for smburl at the very least).<br />
the effective output remains unchanged, we simply have a fake library<br />
now before we turn it into a proper plugin .so.</p>
<p>kdemain as a result was moved to its own file and only gets built into the<br />
final plugin but not the static library as it'd not have any use there<br />
anyway</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>builds and works still</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>BRANCH</strong><div><div>smb-smburl-static</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27800">https://phabricator.kde.org/D27800</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>smb/CMakeLists.txt<br />
smb/kio_smb.cpp<br />
smb/main.cpp</div></div></div><br /><div><strong>To: </strong>sitter, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov<br /></div>