<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27805">View Revision</a></tr></table><br /><div><div><p>I love the direction. +++++</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27805#inline-157084">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ItemCapture.cpp:59</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qWarning</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"No previous image found for capture"</span> <span style="color: #aa2211"><<</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY2</span><span class="p">(</span><span class="n">result</span><span style="color: #aa2211">-></span><span class="n">saveToFile</span><span class="p">(</span><span class="n">dir</span><span class="p">.</span><span class="n">absoluteFilePath</span><span class="p">(</span><span class="n">filePath</span><span class="p">)),</span> <span style="color: #766510">"Unable to store first version of capture."</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't like how we're saving files into the user's source directory directly.</p>
<p style="padding: 0; margin: 8px;">I'm sure we'll get lots of people forgetting to add the files and claiming it works because make test works the second time.</p>
<p style="padding: 0; margin: 8px;">And we'll get other people committing lots of _new.png files committed accidentally.</p>
<hr class="remarkup-hr" />
<p style="padding: 0; margin: 8px;">I think a new temp dir would be best, alternatively we check some env variable/arg that a user can set to specify they want to generate a baseline</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27805#inline-157085">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ItemCapture.cpp:81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY2</span><span class="p">(</span><span class="n">dir</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span class="n">filePath</span><span class="p">),</span> <span style="color: #766510">"Could not remove old capture."</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY2</span><span class="p">(</span><span class="n">dir</span><span class="p">.</span><span class="n">rename</span><span class="p">(</span><span class="n">newFilePath</span><span class="p">,</span> <span class="n">filePath</span><span class="p">),</span> <span style="color: #766510">"Could not rename new capture."</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why are we replacing the image if it's slightly different?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27805#inline-157086">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ItemCapture.h:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">qreal</span> <span class="n">errorMargin</span> <span class="n">READ</span> <span class="n">errorMargin</span> <span class="n">WRITE</span> <span class="n">setErrorMargin</span> <span class="n">NOTIFY</span> <span class="n">errorMarginChanged</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">specify if 1% is</p>
<p style="padding: 0; margin: 8px;">0.01 or 1 ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27805#inline-157083">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmltest.cpp:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QUICK_TEST_MAIN_WITH_SETUP</span><span class="p">(</span><span class="n">Charts</span><span class="p">,</span> <span class="n">Setup</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't know what QUICK_TEXT_MAIN does, but we probably want to make sure we have:</p>
<p style="padding: 0; margin: 8px;">QGuiApplication::setAttribute(AA_DisableHighDpiScaling, true);<br />
QGuiApplication::setDesktopSettingsAware(false);</p>
<p style="padding: 0; margin: 8px;">QQuickWindow::setTextRenderType(the qt rendering)</p>
<p style="padding: 0; margin: 8px;">that should help generating the same thing across machines</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R1049 KQuickCharts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27805">https://phabricator.kde.org/D27805</a></div></div><br /><div><strong>To: </strong>ahiemstra<br /><strong>Cc: </strong>davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>