<table><tr><td style="">iasensio created this revision.<br />iasensio added reviewers: Plasma, mart, davidedmundson.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />iasensio requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27795">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Expose the signal <tt style="background: #ebebeb; font-size: 13px;">captureFinished</tt> from the private helper to <tt style="background: #ebebeb; font-size: 13px;">KeySequenceItem</tt>.<br />
Currently, if we set <tt style="background: #ebebeb; font-size: 13px;">keySequence</tt> from a model and use <tt style="background: #ebebeb; font-size: 13px;">onKeySequenceChanged</tt> to<br />
update that model, a binding loop happens. Using <tt style="background: #ebebeb; font-size: 13px;">onCaptureFinished</tt> prevents that.</p></div></div><br /><div><strong>TEST PLAN</strong><div><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">keySequence: modelData
onCaptureFinished: { modelData = keySequence }</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>BRANCH</strong><div><div>expose_capture</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27795">https://phabricator.kde.org/D27795</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/qmlcontrols/kquickcontrols/KeySequenceItem.qml</div></div></div><br /><div><strong>To: </strong>iasensio, Plasma, mart, davidedmundson<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>