<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27640">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27640#619817" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27640#619817</a>, <a href="https://phabricator.kde.org/p/cordlandwehr/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cordlandwehr</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>My only question is, how is the X-KDE-PluginInfo-License value is evaluated? Are we free to write any value? Or do we have to extend some mechanism? I would be great to also use SPDX identifiers there!</p></div>
</blockquote>
<p>From what I can tell, Plasma itself currently ignores the license info, e.g. there is no display of About data for plasmoids or wallpaper plugins (sadly, IMHO, but no resources to fix myself).</p>
<p>In general X-KDE-PluginInfo+* is feed to KPluginMetaData, which just holds the raw string. The string itself is evaluated e,g,in KAboutPluginDialog via KAboutLicense::byKeyword(), the only place I know about currently (besides deprecated KAboutData::fromPluginMetaData, which does the same KAboutLicense::byKeyword).</p>
<p>KAboutLicense itself once was already extended to support keywords (see <a href="https://phabricator.kde.org/D6672" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D6672</a>), but needs update to latest SPDX identifiers,</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27640#inline-156780">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cordlandwehr</span> wrote in <span style="color: #4b4d51; font-weight: bold;">metadata.desktop:96</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">does this work with our PluginInfo mechanism? actually, I did not yet look into the SPDX license handling in desktop files or any other tooling for outbound licenses for libraries, plugins or applications; same question for the same changes below in the desktop files</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hmpf, this is outdated version, forgot to append to commit before arc diff.<br />
Should be "LGPLv21+" as I had found later that KAboutLicense still only supports the meanwhile deprecated spdx key variants.<br />
Will update next.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27640">https://phabricator.kde.org/D27640</a></div></div><br /><div><strong>To: </strong>kossebau, Plasma, cordlandwehr<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>