<table><tr><td style="">dfaure planned changes to this revision.<br />dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25315">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25315#619436" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25315#619436</a>, <a href="https://phabricator.kde.org/p/rrosch/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@rrosch</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep);</pre></div>
<p>[to] model->openUrl(QUrl::fromLocalFile("/"), KDirModel::ShowRoot);<br />
and don't really know the implications of the change at this point. (Will it "Keep"? Does it matter that I now call the model's openURL vs the dirLister's?)</p></div>
</blockquote>
<p>It's part of the documentation for this change, that you're actually supposed to call model->openUrl(). So yes it matters :-)</p>
<p>Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL.<br />
KDirModel takes care of that.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I couldn't however get the following to work:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QModelIndex index = getIndexFromUrl("/home/myuser");</pre></div></blockquote>
<p>Invalid URL, that's a path, not a URL. You need QUrl::fromLocalFile().</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (index.isValid()) {
treeView->setRootIndex(index.parent());
}</pre></div>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"></pre></div></blockquote>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Which should show the node for "/home" as the root, but is instead giving me a flat listing of all the child nodes without "/home" as the root.</p></blockquote>
<p>Oh, hmm, that's not how setRootIndex works (that's a *view* feature, we can't change that).<br />
I changed the model to have one more node for "/", while I see now that what you want is that it *always* shows a root node even when the root is another directory.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>(Also, it would be great to have a setRootPath() that works in conjunction to expandToUrl or openUrl, to save processing cycles wasted on loading the parts of the model that won't be shown in the new rootIndex, like <a href="https://doc.qt.io/qt-5/qfilesystemmodel.html#setRootPath" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qfilesystemmodel.html#setRootPath</a> )</p></blockquote>
<p>Yes it sounds like that's exactly what's needed in KDirModel. Damn, I need to rework all this then.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>As it is relevant, I also tested the patch at <a href="http://www.davidfaure.fr/2019/kdirmodel_haschildren.diff" class="remarkup-link" target="_blank" rel="noreferrer">http://www.davidfaure.fr/2019/kdirmodel_haschildren.diff</a> for <tt style="background: #ebebeb; font-size: 13px;">hasChildren()</tt>, which works as expected! Thank you!</p></blockquote>
<p>Thanks, posted as <a href="https://phabricator.kde.org/D27731" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27731</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25315">https://phabricator.kde.org/D25315</a></div></div><br /><div><strong>To: </strong>dfaure, stefanocrocco, elvisangelaccio, meven, apol<br /><strong>Cc: </strong>rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>