<table><tr><td style="">sitter requested changes to this revision.<br />sitter added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21795">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21795#inline-156393">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Polkit1Backend.cpp:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">* Copyright (C) 2009 Radek Novacek <rnovacek@redhat.com></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">* Copyright (C) 2009-2010 Dario Freddi <drf@kde.org></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">*</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">According to the diff of the diff you seem to have lost David's copyright</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21795#inline-156392">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Polkit1Backend.cpp:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span class="n">PolkitQt1</span><span style="color: #aa2211">::</span><span class="n">Authority</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">enumerateActionsFinished</span><span class="p">(</span><span class="n">PolkitQt1</span><span style="color: #aa2211">::</span><span class="n">ActionDescription</span><span style="color: #aa2211">::</span><span class="n">List</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">updateCachedActions</span><span class="p">(</span><span class="n">PolkitQt1</span><span style="color: #aa2211">::</span><span class="n">ActionDescription</span><span style="color: #aa2211">::</span><span class="n">List</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there a reason you use stringy connection syntax instead of &member syntax?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21795#inline-156391">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Polkit1Backend.cpp:178</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">bool</span> <span class="n">Polkit1Backend</span><span style="color: #aa2211">::</span><span class="n">isCallerAuthorized</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="n">action</span><span class="p">,</span> <span class="n">QByteArray</span> <span class="n">callerID</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">bool</span> <span class="n">Polkit1Backend</span><span style="color: #aa2211">::</span><span class="n">isCallerAuthorized</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span class="n">action</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n">QByteArray</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="n">callerID<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QVariantMap</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span class="n"><span class="bright">details</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">action has & on the wrong size of the space, same for details ;)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21795#inline-156390">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Polkit1Backend.cpp:239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Wait max 2 seconds</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QEventLoop</span> <span class="n">e</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QTimer</span><span style="color: #aa2211">::</span><span class="n">singleShot</span><span class="p">(</span><span style="color: #601200">200</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">e</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">quit</span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Mhhhh. Mhhhhhhhh. I don't really have a suggestion here, but this is an incredibly dangerous change. Nested event loops can cause all sorts of negative effects. That's why the isValid had a note in the documentation, to tell the frontend dev to be careful. By adding a new loop in existing api we add a pit to fall into. I really don't know what can be done about it though. Could we get by with 1 second maybe?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21795#inline-156387">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kauthaction.cpp:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#include</span> <span class="cpf"><QtGlobal></span><span style="color: #304a96"></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#include</span> <span class="cpf"><QRegExp></span><span style="color: #304a96"></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think that is deprecated, or at least not recommended for use anymore. You'll want QRegularExpression</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21795#inline-156389">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kauthaction.cpp:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QVariantMap</span> <span class="n">args</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">bool</span> <span class="n">valid</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QWidget</span> <span style="color: #aa2211">*</span><span class="n">parent</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">nullptr</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Mh, minor annoyance. valid and timeout should get their defaults set here as a more modern best practice and also because parent is already set for consistency. That default ctor is kinda pointless then and should be dropped IMHO.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R283 KAuth</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21795">https://phabricator.kde.org/D21795</a></div></div><br /><div><strong>To: </strong>feverfew, apol, bruns, davidedmundson, Frameworks, dfaure, cfeck, sitter, chinmoyr<br /><strong>Cc: </strong>elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns<br /></div>