<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: VDG, ndavis, Frameworks, sitter.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27557">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Right now we have 24px monochrome icons for compatibility with GTK apps, which use icons<br />
of this size. However they are visually identical to the 22px versions, with one pixel of<br />
padding on all sides. Manually creating them is tedious busywork.</p>

<p>This patch automatically generates 24px monochrome icons from the 22px versions for<br />
action, device, places, and status icons by editing the SVG files to increase the size<br />
of the viewbox and apply a (1,1) translation to the content.</p>

<p>That way I implemented this seems to work pretty reliably on the icon generation side.<br />
However I am less sure about how it is integrated into the CMake files. It works, but if<br />
I did it wrong, let me know.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Delete <tt style="background: #ebebeb; font-size: 13px;">~/kde/usr/share/icons/{breeze,breeze-dark}</tt> (or wherever your icons live)<br />
Apply patch and build<br />
Look in <tt style="background: #ebebeb; font-size: 13px;">~/kde/usr/share/icons/{breeze,breeze-dark}/{devices,actions,places,status}/24</tt><br />
Open Cuttlefish</p>

<p>See that everything is awesome</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>BRANCH</strong><div><div>autogenerate-24px-icons (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27557">https://phabricator.kde.org/D27557</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>generate-24px-versions.sh<br />
icons-dark/CMakeLists.txt<br />
icons-dark/actions/24/acrobat.svg<br />
icons-dark/actions/24/activities.svg<br />
icons-dark/actions/24/address-book-new.svg<br />
icons-dark/actions/24/align-horizontal-baseline.svg<br />
icons-dark/actions/24/align-horizontal-bottom-out.svg<br />
icons-dark/actions/24/align-horizontal-center.svg<br />
icons-dark/actions/24/align-horizontal-left-out.svg<br />
icons-dark/actions/24/align-horizontal-left-to-anchor.svg<br />
icons-dark/actions/24/align-horizontal-left.svg<br />
icons-dark/actions/24/align-horizontal-node.svg<br />
icons-dark/actions/24/align-horizontal-right-out.svg<br />
icons-dark/actions/24/align-horizontal-right-to-anchor.svg<br />
icons-dark/actions/24/align-horizontal-right.svg<br />
icons-dark/actions/24/align-horizontal-top-out.svg<br />
icons-dark/actions/24/align-vertical-baseline.svg<br />
icons-dark/actions/24/align-vertical-bottom-out.svg<br />
icons-dark/actions/24/align-vertical-bottom-to-anchor.svg<br />
icons-dark/actions/24/align-vertical-bottom.svg<br />
icons-dark/actions/24/align-vertical-center.svg<br />
icons-dark/actions/24/align-vertical-node.svg<br />
icons-dark/actions/24/align-vertical-top-out.svg<br />
icons-dark/actions/24/align-vertical-top-to-anchor.svg<br />
icons-dark/actions/24/align-vertical-top.svg<br />
icons-dark/actions/24/amarok_cart_view.svg<br />
icons-dark/actions/24/application-exit.svg<br />
icons-dark/actions/24/application-menu.svg<br />
icons-dark/actions/24/appointment-new.svg<br />
icons-dark/actions/24/archive-extract.svg<br />
icons-dark/actions/24/archive-insert-directory.svg<br />
icons-dark/actions/24/archive-insert.svg<br />
icons-dark/actions/24/archive-remove.svg<br />
icons-dark/actions/24/arrow-down-double.svg<br />
icons-dark/actions/24/arrow-down.svg<br />
icons-dark/actions/24/arrow-left-double.svg<br />
icons-dark/actions/24/arrow-left.svg<br />
icons-dark/actions/24/arrow-right-double.svg<br />
icons-dark/actions/24/arrow-right.svg<br />
icons-dark/actions/24/arrow-up-double.svg<br />
icons-dark/actions/24/arrow-up.svg<br />
icons-dark/actions/24/audio-volume-high.svg<br />
icons-dark/actions/24/audio-volume-low.svg<br />
icons-dark/actions/24/audio-volume-medium.svg<br />
icons-dark/actions/24/audio-volume-muted.svg<br />
icons-dark/actions/24/auto-scale-all.svg<br />
icons-dark/actions/24/auto-scale-x.svg<br />
icons-dark/actions/24/auto-scale-y.svg<br />
icons-dark/actions/24/autocorrection.svg<br />
icons-dark/actions/24/bookmark-new-list.svg<br />
icons-dark/actions/24/bookmark-new.svg<br />
icons-dark/actions/24/bookmark-toolbar.svg<br />
icons-dark/actions/24/bookmarks-organize.svg<br />
icons-dark/actions/24/bookmarks.svg<br />
icons-dark/actions/24/bordertool.svg<br />
icons-dark/actions/24/call-start.svg<br />
icons-dark/actions/24/call-stop.svg<br />
icons-dark/actions/24/character-set.svg<br />
icons-dark/actions/24/checkbox.svg<br />
icons-dark/actions/24/chronometer-lap.svg<br />
icons-dark/actions/24/chronometer-pause.svg<br />
icons-dark/actions/24/chronometer-reset.svg<br />
icons-dark/actions/24/chronometer-start.svg<br />
icons-dark/actions/24/chronometer.svg<br />
icons-dark/actions/24/class-or-package.svg<br />
icons-dark/actions/24/code-block.svg<br />
icons-dark/actions/24/code-class.svg<br />
icons-dark/actions/24/code-context.svg<br />
icons-dark/actions/24/code-function.svg<br />
icons-dark/actions/24/code-typedef.svg<br />
icons-dark/actions/24/code-variable.svg<br />
icons-dark/actions/24/collapse-all.svg<br />
icons-dark/actions/24/color-fill.svg<br />
icons-dark/actions/24/color-gradient.svg<br />
icons-dark/actions/24/color-management.svg<br />
icons-dark/actions/24/color-picker-black.svg<br />
icons-dark/actions/24/color-picker-grey.svg<br />
icons-dark/actions/24/color-picker-white.svg<br />
icons-dark/actions/24/color-picker.svg<br />
icons-dark/actions/24/colormanagement.svg<br />
icons-dark/actions/24/configure-shortcuts.svg<br />
icons-dark/actions/24/configure-toolbars.svg<br />
icons-dark/actions/24/configure.svg<br />
icons-dark/actions/24/contact-new.svg<br />
icons-dark/actions/24/contrast.svg<br />
icons-dark/actions/24/cursor-arrow.svg<br />
icons-dark/actions/24/dashboard-show.svg<br />
icons-dark/actions/24/database-change-key.svg<br />
icons-dark/actions/24/database-index.svg<br />
icons-dark/actions/24/debug-execute-from-cursor.svg<br />
icons-dark/actions/24/debug-execute-to-cursor.svg<br />
icons-dark/actions/24/debug-run-cursor.svg<br />
icons-dark/actions/24/debug-run.svg<br />
icons-dark/actions/24/debug-step-instruction.svg<br />
icons-dark/actions/24/debug-step-into-instruction.svg<br />
icons-dark/actions/24/debug-step-into.svg<br />
icons-dark/actions/24/debug-step-out.svg<br />
icons-dark/actions/24/debug-step-over.svg<br />
icons-dark/actions/24/dialog-cancel.svg<br />
icons-dark/actions/24/dialog-close.svg<br />
icons-dark/actions/24/dialog-messages.svg<br />
icons-dark/actions/24/dialog-ok-apply.svg<br />
icons-dark/actions/24/dialog-ok.svg<br />
icons-dark/actions/24/dialog-xml-editor.svg<br />
icons-dark/actions/24/dirsync.svg<br />
icons-dark/actions/24/distribute-graph-directed.svg<br />
icons-dark/actions/24/distribute-graph.svg<br />
icons-dark/actions/24/distribute-horizontal-baseline.svg<br />
icons-dark/actions/24/distribute-horizontal-center.svg<br />
icons-dark/actions/24/distribute-horizontal-equal.svg<br />
icons-dark/actions/24/distribute-horizontal-gaps.svg<br />
icons-dark/actions/24/distribute-horizontal-left.svg<br />
icons-dark/actions/24/distribute-horizontal-margin.svg<br />
icons-dark/actions/24/distribute-horizontal-node.svg<br />
icons-dark/actions/24/distribute-horizontal-page.svg<br />
icons-dark/actions/24/distribute-horizontal-right.svg<br />
icons-dark/actions/24/distribute-horizontal-x.svg<br />
icons-dark/actions/24/distribute-horizontal.svg<br />
icons-dark/actions/24/distribute-randomize.svg<br />
icons-dark/actions/24/distribute-remove-overlaps.svg<br />
icons-dark/actions/24/distribute-unclump.svg<br />
icons-dark/actions/24/distribute-vertical-baseline.svg<br />
icons-dark/actions/24/distribute-vertical-bottom.svg<br />
icons-dark/actions/24/distribute-vertical-center.svg<br />
icons-dark/actions/24/distribute-vertical-equal.svg<br />
icons-dark/actions/24/distribute-vertical-gaps.svg<br />
icons-dark/actions/24/distribute-vertical-margin.svg<br />
icons-dark/actions/24/distribute-vertical-node.svg<br />
icons-dark/actions/24/distribute-vertical-page.svg<br />
icons-dark/actions/24/distribute-vertical-top.svg<br />
icons-dark/actions/24/distribute-vertical-y.svg<br />
icons-dark/actions/24/distribute-vertical.svg<br />
icons-dark/actions/24/document-close.svg<br />
icons-dark/actions/24/document-decrypt.svg<br />
icons-dark/actions/24/document-edit-decrypt-verify.svg<br />
icons-dark/actions/24/document-edit-decrypt.svg<br />
icons-dark/actions/24/document-edit-encrypt.svg<br />
icons-dark/actions/24/document-edit-sign-encrypt.svg<br />
icons-dark/actions/24/document-edit-sign.svg<br />
icons-dark/actions/24/document-edit-verify.svg<br />
icons-dark/actions/24/document-edit.svg<br />
icons-dark/actions/24/document-encrypt.svg<br />
icons-dark/actions/24/document-encrypted.svg<br />
icons-dark/actions/24/document-export-table.svg<br />
icons-dark/actions/24/document-export.svg<br />
icons-dark/actions/24/document-import.svg<br />
icons-dark/actions/24/document-multiple.svg<br />
icons-dark/actions/24/document-new-from-template.svg<br />
icons-dark/actions/24/document-new.svg<br />
icons-dark/actions/24/document-open-folder.svg<br />
icons-dark/actions/24/document-open-recent.svg<br />
icons-dark/actions/24/document-open-remote.svg<br />
icons-dark/actions/24/document-open.svg<br />
icons-dark/actions/24/document-preview-archive.svg<br />
icons-dark/actions/24/document-preview.svg<br />
icons-dark/actions/24/document-print-direct.svg<br />
icons-dark/actions/24/document-print-frame.svg<br />
icons-dark/actions/24/document-print-preview.svg<br />
icons-dark/actions/24/document-print.svg<br />
icons-dark/actions/24/document-properties.svg<br />
icons-dark/actions/24/document-revert.svg<br />
icons-dark/actions/24/document-save-all.svg<br />
icons-dark/actions/24/document-save-as-template.svg<br />
icons-dark/actions/24/document-save-as.svg<br />
icons-dark/actions/24/document-save.svg<br />
icons-dark/actions/24/document-share.svg<br />
icons-dark/actions/24/document-sign.svg<br />
icons-dark/actions/24/document-swap.svg<br />
icons-dark/actions/24/documentation.svg<br />
icons-dark/actions/24/documentinfo.svg<br />
icons-dark/actions/24/download-later.svg<br />
icons-dark/actions/24/download.svg<br />
icons-dark/actions/24/draw-arrow-back.svg<br />
icons-dark/actions/24/draw-arrow-down.svg<br />
icons-dark/actions/24/draw-arrow-forward.svg<br />
icons-dark/actions/24/draw-arrow-up.svg<br />
icons-dark/actions/24/draw-bezier-curves.svg<br />
icons-dark/actions/24/draw-brush.svg<br />
icons-dark/actions/24/draw-calligraphic.svg<br />
icons-dark/actions/24/draw-circle.svg<br />
icons-dark/actions/24/draw-connector.svg<br />
icons-dark/actions/24/draw-cross.svg<br />
icons-dark/actions/24/draw-cuboid.svg<br />
icons-dark/actions/24/draw-donut.svg<br />
icons-dark/actions/24/draw-ellipse.svg<br />
icons-dark/actions/24/draw-eraser.svg<br />
icons-dark/actions/24/draw-freehand.svg<br />
icons-dark/actions/24/draw-halfcircle1.svg<br />
icons-dark/actions/24/draw-halfcircle2.svg<br />
icons-dark/actions/24/draw-halfcircle3.svg<br />
icons-dark/actions/24/draw-halfcircle4.svg<br />
icons-dark/actions/24/draw-line.svg<br />
icons-dark/actions/24/draw-path.svg<br />
icons-dark/actions/24/draw-polygon-star.svg<br />
icons-dark/actions/24/draw-polygon.svg<br />
icons-dark/actions/24/draw-polyline.svg<br />
icons-dark/actions/24/draw-rectangle.svg<br />
icons-dark/actions/24/draw-spiral.svg<br />
icons-dark/actions/24/draw-square-inverted-corners.svg<br />
icons-dark/actions/24/draw-star.svg<br />
icons-dark/actions/24/draw-text.svg<br />
icons-dark/actions/24/draw-triangle.svg<br />
icons-dark/actions/24/draw-triangle1.svg<br />
icons-dark/actions/24/draw-triangle2.svg<br />
icons-dark/actions/24/draw-triangle3.svg<br />
icons-dark/actions/24/draw-triangle4.svg<br />
icons-dark/actions/24/draw-watercolor.svg<br />
icons-dark/actions/24/edit-bomb.svg<br />
icons-dark/actions/24/edit-clear-all.svg<br />
icons-dark/actions/24/edit-clear-history.svg<br />
icons-dark/actions/24/edit-clear-list.svg<br />
icons-dark/actions/24/edit-clear-locationbar-ltr.svg<br />
icons-dark/actions/24/edit-clear-locationbar-rtl.svg<br />
icons-dark/actions/24/edit-clear.svg<br />
icons-dark/actions/24/edit-clone.svg<br />
icons-dark/actions/24/edit-copy.svg<br />
icons-dark/actions/24/edit-cut.svg<br />
icons-dark/actions/24/edit-delete-shred.svg<br />
icons-dark/actions/24/edit-delete.svg<br />
icons-dark/actions/24/edit-download.svg<br />
icons-dark/actions/24/edit-find-mail.svg<br />
icons-dark/actions/24/edit-find-project.svg<br />
icons-dark/actions/24/edit-find-replace.svg<br />
icons-dark/actions/24/edit-find-user.svg<br />
icons-dark/actions/24/edit-find.svg<br />
icons-dark/actions/24/edit-group.svg<br />
icons-dark/actions/24/edit-guides.svg<br />
icons-dark/actions/24/edit-image-face-add.svg<br />
icons-dark/actions/24/edit-image-face-detect.svg<br />
icons-dark/actions/24/edit-image-face-recognize.svg<br />
icons-dark/actions/24/edit-image-face-show.svg<br />
icons-dark/actions/24/edit-node.svg<br />
icons-dark/actions/24/edit-none.svg<br />
icons-dark/actions/24/edit-paste-in-place.svg<br />
icons-dark/actions/24/edit-paste.svg<br />
icons-dark/actions/24/edit-redo.svg<br />
icons-dark/actions/24/edit-rename.svg<br />
icons-dark/actions/24/edit-select-all.svg<br />
icons-dark/actions/24/edit-select-invert.svg<br />
icons-dark/actions/24/edit-select-lasso.svg<br />
icons-dark/actions/24/edit-select-none.svg<br />
icons-dark/actions/24/edit-select.svg<br />
icons-dark/actions/24/edit-table-cell-merge.svg<br />
icons-dark/actions/24/edit-table-cell-split.svg<br />
icons-dark/actions/24/edit-table-delete-column.svg<br />
icons-dark/actions/24/edit-table-delete-row.svg<br />
icons-dark/actions/24/edit-table-insert-column-left.svg<br />
icons-dark/actions/24/edit-table-insert-column-right.svg<br />
icons-dark/actions/24/edit-table-insert-row-above.svg<br />
icons-dark/actions/24/edit-table-insert-row-below.svg<br />
(1780 more files...)</div></div></div><br /><div><strong>To: </strong>ngraham, VDG, ndavis, Frameworks, sitter<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>