<table><tr><td style="">cordlandwehr created this revision.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />cordlandwehr requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27429">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Add license files are required by REUSE and add license<br />

files as reuqired by REUSE.</p>

<p>Please note the following points:</p>

<ul class="remarkup-list">

<li class="remarkup-list-item">all links to dead webpages were removed from license statements</li>

<li class="remarkup-list-item">I do not think that the ID markers are still needed, which are contained in several license headers (<a href="https://phabricator.kde.org/p/mirko/" style="

              border-color: #f1f7ff;

              color: #19558d;

              background-color: #f1f7ff;

                border: 1px solid transparent;

                border-radius: 3px;

                font-weight: bold;

                padding: 0 4px;">@mirko</a>: are they still needed?)</li>

<li class="remarkup-list-item">In both src/examples/ItemdDelegate.cpp/.h there is a license clarification that this file may be linked with any version of Qt. I do not see that this license clarification is needed, because that automatically comes with the LGPL. (<span class="phabricator-remarkup-mention-unknown">@all</span>: what is your opinion?)</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R279 ThreadWeaver</div></div></div><br /><div><strong>BRANCH</strong><div><div>spdxHeaders</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27429">https://phabricator.kde.org/D27429</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>LICENSES/LGPL-2.0-or-later.txt<br />

autotests/AppendCharacterAndVerifyJob.cpp<br />

autotests/AppendCharacterAndVerifyJob.h<br />

autotests/AppendCharacterJob.h<br />

autotests/DeleteTest.cpp<br />

autotests/DeleteTest.h<br />

autotests/JobLoggingDecorator.cpp<br />

autotests/JobLoggingDecorator.h<br />

autotests/JobLoggingWeaver.cpp<br />

autotests/JobLoggingWeaver.h<br />

autotests/JobTests.cpp<br />

autotests/JobTests.h<br />

autotests/LifecycleTests.cpp<br />

autotests/QueueFactoryTests.cpp<br />

autotests/QueueTests.cpp<br />

autotests/QueueTests.h<br />

autotests/SequencesTests.cpp<br />

autotests/SequencesTests.h<br />

autotests/ShutdownOnQApplicationQuitTests.cpp<br />

autotests/WaitForIdleAndFinished.cpp<br />

autotests/WaitForIdleAndFinished.h<br />

autotests/run-n-tests.py<br />

benchmarks/QueueBenchmarks.cpp<br />

examples/HelloInternet/main.cpp<br />

examples/HelloWorld/HelloWorld.cpp<br />

examples/HelloWorldRaw/HelloWorldRaw.cpp<br />

examples/ThumbNailer/Benchmark.cpp<br />

examples/ThumbNailer/Benchmark.h<br />

examples/ThumbNailer/ComputeThumbNailJob.cpp<br />

examples/ThumbNailer/ComputeThumbNailJob.h<br />

examples/ThumbNailer/FileLoaderJob.cpp<br />

examples/ThumbNailer/FileLoaderJob.h<br />

examples/ThumbNailer/Image.cpp<br />

examples/ThumbNailer/Image.h<br />

examples/ThumbNailer/ImageListFilter.cpp<br />

examples/ThumbNailer/ImageListFilter.h<br />

examples/ThumbNailer/ImageLoaderJob.cpp<br />

examples/ThumbNailer/ImageLoaderJob.h<br />

examples/ThumbNailer/ItemDelegate.cpp<br />

examples/ThumbNailer/ItemDelegate.h<br />

examples/ThumbNailer/MainWindow.cpp<br />

examples/ThumbNailer/MainWindow.h<br />

examples/ThumbNailer/Model.cpp<br />

examples/ThumbNailer/Model.h<br />

examples/ThumbNailer/PriorityDecorator.cpp<br />

examples/ThumbNailer/PriorityDecorator.h<br />

examples/ThumbNailer/ThumbNailer.cpp<br />

src/collection.cpp<br />

src/collection.h<br />

src/collection_p.cpp<br />

src/collection_p.h<br />

src/debuggingaids.cpp<br />

src/debuggingaids.h<br />

src/dependency.cpp<br />

src/dependency.h<br />

src/dependencypolicy.cpp<br />

src/dependencypolicy.h<br />

src/destructedstate.cpp<br />

src/destructedstate.h<br />

src/exception.cpp<br />

src/exception.h<br />

src/executewrapper.cpp<br />

src/executewrapper_p.h<br />

src/executor.cpp<br />

src/executor_p.h<br />

src/iddecorator.cpp<br />

src/iddecorator.h<br />

src/inconstructionstate.cpp<br />

src/inconstructionstate.h<br />

src/job.cpp<br />

src/job.h<br />

src/job_p.cpp<br />

src/job_p.h<br />

src/jobinterface.h<br />

src/jobpointer.h<br />

src/lambda.h<br />

src/managedjobpointer.h<br />

src/qobjectdecorator.cpp<br />

src/qobjectdecorator.h<br />

src/queue.cpp<br />

src/queue.h<br />

src/queueapi.cpp<br />

src/queueapi.h<br />

src/queueing.h<br />

src/queueinterface.h<br />

src/queuepolicy.h<br />

src/queuesignals.cpp<br />

src/queuesignals.h<br />

src/queuesignals_p.cpp<br />

src/queuesignals_p.h<br />

src/queuestream.cpp<br />

src/queuestream.h<br />

src/resourcerestrictionpolicy.cpp<br />

src/resourcerestrictionpolicy.h<br />

src/sequence.cpp<br />

src/sequence.h<br />

src/sequence_p.cpp<br />

src/sequence_p.h<br />

src/shuttingdownstate.cpp<br />

src/shuttingdownstate.h<br />

src/state.cpp<br />

src/state.h<br />

src/suspendedstate.cpp<br />

src/suspendedstate.h<br />

src/suspendingstate.cpp<br />

src/suspendingstate.h<br />

src/thread.cpp<br />

src/thread.h<br />

src/threadweaver.cpp<br />

src/threadweaver.h<br />

src/weaver.cpp<br />

src/weaver.h<br />

src/weaver_p.cpp<br />

src/weaver_p.h<br />

src/weaverimplstate.cpp<br />

src/weaverimplstate.h<br />

src/weaverinterface.h<br />

src/workinghardstate.cpp<br />

src/workinghardstate.h</div></div></div><br /><div><strong>To: </strong>cordlandwehr<br /><strong>Cc: </strong>kde-frameworks-devel, mirko, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>