<table><tr><td style="">cgiboudeaux added subscribers: winterz, cgiboudeaux.<br />cgiboudeaux added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27363">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154519">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holidayregion.cpp:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">// Copied from qlocale_data_p.h and qlocale.h</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">// Copyright<span class="bright"> (C)</span> 2014 Digia Plc and/or its subsidiary(-ies).</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// <span class="bright">SPDX-File</span>Copyright<span class="bright">Text:</span> 2014 Digia Plc and<span class="bright"> </span>/or its subsidiary(-ies).</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">// To later be replaced by OpenCodes or public Qt api</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think it should be changed here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154520">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lunarphase.cpp:6</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> <span class="bright">Copyright (c) 1989, 1993 //krazy:exclude=copyright</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> The Regents of the University of California. All rights reserved.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright"> SPDX-FileCopyrightText: 1989, 1993 The Regents of the University of California. All rights reserved.</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This looks suspicious</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/winterz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@winterz</a> ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154522">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holidayparserdriverplan.cpp:6-13</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Preston Brown <pbrown@kde.org><span class="bright"> and</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Reinhold Kainhofer <reinhold@kainhofer.com></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-FileCopyrightText: </span>Preston Brown <pbrown@kde.org></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-FileCopyrightText: </span>Reinhold Kainhofer <reinhold@kainhofer.com></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> Portions contributed by</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Peter Littlefield <plittle@sofkin.ca></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Armin Liebl <liebla@informatik.tu-muenchen.de></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Efthimios Mavrogeorgiadis <emav@enl.auth.gr></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-FileCopyrightText: </span>Peter Littlefield <plittle@sofkin.ca></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-FileCopyrightText: </span>Armin Liebl <liebla@informatik.tu-muenchen.de></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-FileCopyrightText: </span>Efthimios Mavrogeorgiadis <emav@enl.auth.gr></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The original text lacks clarity. Are these file contributors or copyright holders? <a href="https://phabricator.kde.org/p/winterz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@winterz</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154521">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holidayparserdriverplan.cpp:15</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Major rewrite using Bison C++ skeleton<span class="bright">:</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Copyright 2010 John Layt <john@layt.net></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> Major rewrite using Bison C++ skeleton<span class="bright"> by</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-File</span>Copyright<span class="bright">Text:</span> 2010 John Layt <john@layt.net></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why is "by" needed here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154523">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holidayparserplan.ypp:3-10</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> SPDX-FileCopyrightText: Thomas Driemeyer <thomas@bitrot.de>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "> Adapted for use in KOrganizer by
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> Preston Brown <pbrown@kde.org> and
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> Reinhold Kainhofer <reinhold@kainhofer.com>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright">SPDX-FileCopyrightText: </span>Preston Brown <pbrown@kde.org> and
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright">SPDX-FileCopyrightText: </span>Reinhold Kainhofer <reinhold@kainhofer.com>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "> Portions contributed by
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same question for this file</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154524">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holidayscannerplan.cpp:1297-1301</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> Original version from plan by Thomas Driemeyer <thomas@bitrot.de></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> Adapted for use in KOrganizer by</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> Preston Brown <pbrown@kde.org> and</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> Reinhold Kainhofer <reinhold@kainhofer.com></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">and these lines were not updated</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154525">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qcalendarsystem.cpp:833</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> \legalese</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> Copyright<span class="bright"> (c)</span> 1989 The Regents of the University of California.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> <span class="bright">SPDX-File</span>Copyright<span class="bright">Text:</span> 1989 The Regents of the University of California<span class="bright"> </span>.</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> All rights reserved.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">also looks wrong</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R175 KHolidays</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27363">https://phabricator.kde.org/D27363</a></div></div><br /><div><strong>To: </strong>cordlandwehr<br /><strong>Cc: </strong>cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>