<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26407">View Revision</a></tr></table><br /><div><div><p>We might want to use Solid instead since it is capable of sending signals when mnttab is updated, rather than like here having a mount point list updated every 5 seconds.<br />
With this code we might have issues with potential run condition : when there is a mount within the 5 seconds cache refresh window and this function is called, it will return incorrect data by default mount point for / .<br />
If this filesystem becomes unresponsive right away, this will cause a freeze because the slowness state would be incorrect.</p>
<p>And a great thing I learned more about at Fosdem, there is a new upcoming Linux API io_uring <a href="https://lwn.net/Articles/810414/" class="remarkup-link" target="_blank" rel="noreferrer">https://lwn.net/Articles/810414/</a> that will allow us to make asynchronous statx calls with timeout (linux 5.6+), making dealing with unresponsive file system that much easier.</p>
<p>In the meantime this works.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26407">https://phabricator.kde.org/D26407</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, ngraham, broulik, dfaure<br /><strong>Cc: </strong>anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>