<table><tr><td style="">mwolff created this revision.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />mwolff requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27065">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Reading through the code, I realized that the isRemovable check<br />
returned true when the kDADiskDescriptionDeviceInternalKey property<br />
is set to true. But that sounds like the check needs to be inverted:</p>

<p>According to [1] e.g. a disk is non-removable when it is internal.<br />
And kDADiskDescriptionDeviceInternalKey returns whether the disk<br />
is internal, not external.</p>

<p>[1]: <a href="https://stackoverflow.com/questions/38499860/thunderbolt-drives-not-marked-as-ejectable-in-disk-arbitration-iokit-although-th#comment64407405_38499860" class="remarkup-link" target="_blank" rel="noreferrer">https://stackoverflow.com/questions/38499860/thunderbolt-drives-not-marked-as-ejectable-in-disk-arbitration-iokit-although-th#comment64407405_38499860</a></p>

<p>I do not own a device with IOKit platfor, so I cannot actually test<br />
whether this patch is correct or not.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27065">https://phabricator.kde.org/D27065</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/solid/devices/backends/iokit/iokitstorage.cpp</div></div></div><br /><div><strong>To: </strong>mwolff<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>