<table><tr><td style="">zzag accepted this revision.<br />zzag added a subscriber: davidedmundson.<br />zzag added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26858">View Revision</a></tr></table><br /><div><div><p>Code-wise, this change looks good. I don't have a tablet device to test this patch so you may want to wait for a +1 from <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a>.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26858#inline-152506">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablet_interface.cpp:369</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span class="n">zwp_tablet_manager_v2_get_tablet_seat</span><span class="p">(</span><span class="n">Resource</span> <span style="color: #aa2211">*</span><span class="n">resource</span><span class="p">,</span> <span style="color: #aa4000">uint32_t</span> <span class="n">tablet_seat</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">struct</span> <span style="color: #aa2211">::</span><span class="n">wl_resource</span> <span style="color: #aa2211">*</span><span class="n">seat_resource</span><span class="p">)</span> <span style="color: #aa4000">override</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">SeatInterface</span><span style="color: #aa2211">*</span> <span class="n">seat</span> <span style="color: #aa2211">=</span> <span class="n">SeatInterface</span><span style="color: #aa2211">::</span><span class="n">get</span><span class="p">(</span><span class="n">seat_resource</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The opening brace must be on its own line.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26858#inline-152507">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablet_interface.cpp:370</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">struct</span> <span style="color: #aa2211">::</span><span class="n">wl_resource</span> <span style="color: #aa2211">*</span><span class="n">seat_resource</span><span class="p">)</span> <span style="color: #aa4000">override</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">SeatInterface</span><span style="color: #aa2211">*</span> <span class="n">seat</span> <span style="color: #aa2211">=</span> <span class="n">SeatInterface</span><span style="color: #aa2211">::</span><span class="n">get</span><span class="p">(</span><span class="n">seat_resource</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">TabletSeatInterface</span> <span style="color: #aa2211">*</span><span class="n">tsi</span> <span style="color: #aa2211">=</span> <span class="n">get</span><span class="p">(</span><span class="n">seat</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">SeatInterface</span> <span style="color: #aa2211">*</span><span class="n">seat</span> <span style="color: #aa2211">=</span> <span class="n">SeatInterface</span><span style="color: #aa2211">::</span><span class="n">get</span><span class="p">(</span><span class="n">seat_resource</span><span class="p">);</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>BRANCH</strong><div><div>apol/tablet-unstable-v2-1</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26858">https://phabricator.kde.org/D26858</a></div></div><br /><div><strong>To: </strong>apol, KWin, Frameworks, zzag<br /><strong>Cc: </strong>davidedmundson, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>