<table><tr><td style="">waqar added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26346">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26346#inline-148601">View Inline</a><span style="color: #4b4d51; font-weight: bold;">guesslanguage.cpp:745</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">while</span> <span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">hasNext</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">counter</span> <span style="color: #aa2211"><</span> <span class="n">m_maxItems</span> <span style="color: #aa2211">&&</span> <span class="n">confidence</span> <span style="color: #aa2211"><</span> <span class="n">m_minConfidence</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">while</span> <span class="p">(</span><span class="n">it</span><span class="p">.</span><span class="n">hasNext</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">counter</span> <span style="color: #aa2211"><</span> <span class="n">m_maxItems</span> <span style="color: #aa2211">&&</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_minConfidence</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0.0</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n">confidence</span> <span style="color: #aa2211"><</span> <span class="n">m_minConfidence<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">it</span><span class="p">.</span><span class="n">next</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wasn't able to see its usefulness directly, I had to change  <tt style="background: #ebebeb; font-size: 13px;">MIN_RELIABILITY</tt> to <tt style="background: #ebebeb; font-size: 13px;">0.0</tt> (in LanguageFilter) to see its effects.</p>

<p style="padding: 0; margin: 8px;">But how about just doing <tt style="background: #ebebeb; font-size: 13px;">confidence <= m_minConfidence</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R246 Sonnet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26346">https://phabricator.kde.org/D26346</a></div></div><br /><div><strong>To: </strong>mludwig, Frameworks<br /><strong>Cc: </strong>waqar, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>