<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26782">View Revision</a></tr></table><br /><div><div><p>Oh, I thought we already did this. +1 since it was explicitly the plan.</p>

<p>But should we just hide them, or not even create them in the first place? Creating hidden-by-default entries seems a bit off.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26782#inline-151506">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesmodel.cpp:361</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                                              <span class="n">QUrl</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"timeline:/today"</span><span class="p">)),</span>  <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"go-jump-today"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">KFilePlacesItem</span><span style="color: #aa2211">::</span><span class="n">createSystemBookmark</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">bookmarkManager</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">modifieldYesterday</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">KFilePlacesItem</span><span style="color: #aa2211">::</span><span class="n">createSystemBookmark</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">bookmarkManager</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                                              <span class="n">I18NC_NOOP</span><span class="p">(</span><span style="color: #766510">"KFile System Bookmarks"</span><span class="p">,</span> <span style="color: #766510">"Modified Yesterday"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">space before the <tt style="background: #ebebeb; font-size: 13px;">=</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26782">https://phabricator.kde.org/D26782</a></div></div><br /><div><strong>To: </strong>meven, ngraham, VDG, Plasma, hein<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>