<table><tr><td style="">niccolove added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25015">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25015#596684" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25015#596684</a>, <a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>The masks have a rather odd shape and it's not pixel aligned, which might mean something is wrong: <br />
<a href="https://phabricator.kde.org/F7891523" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7891523: Screenshot_20200118_225818.PNG</a><br />
It's different from master, which looks pretty normal: <br />
<a href="https://phabricator.kde.org/F7891527" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7891527: Screenshot_20200118_230209.PNG</a></p></div>
</blockquote>
<p>I know this was going to seem weird, but: the only way to get pixel-perfect mask is to add nodes to the shape, but if I do that, the mask is no longer correctly detected. I tried to group different shapes to be pixel perfect, but that does not work as well. They only way seem to be a single curve, that can only approximate the actual shape. Currently, Breeze Masks are *not* working, although they sure look better than mine. No idea why. Do you have any tip here?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>the <tt style="background: #ebebeb; font-size: 13px;">panel-background</tt> and <tt style="background: #ebebeb; font-size: 13px;">tooltip</tt> SVGs, the shadow was changed, but the tooltip/panel background was not.<br />
<a href="https://phabricator.kde.org/F7891542" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7891542: Screenshot_20200118_231610.PNG</a></p></blockquote>
<p>Mhh, weird. I'll fix that.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I get the impression that these were changed with the node tool rather than creating the corners from rounded rectangles. I guess that works as long as all the svg corners are consistent with each other, but it's inconsistent with the QStyle and could still lead to visible pixel misalignment when the UI is scaled up.<br />
<a href="https://phabricator.kde.org/F7891536" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7891536: Screenshot_20200118_230921.PNG</a></p></blockquote>
<p>This is already what is done in master though, right? I'm not sure rounded rectangles corner can be used, and all the pieces should be different elements</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Why is <tt style="background: #ebebeb; font-size: 13px;">widgets/background.svg</tt> different from the other ones? Maybe there's a good reason, since it's also different in the master branch, but its very odd.<br />
<a href="https://phabricator.kde.org/F7891628" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7891628: Screenshot_20200118_232026.PNG</a></p></blockquote>
<p>No idea. I did not change that file.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>bettershadows (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25015">https://phabricator.kde.org/D25015</a></div></div><br /><div><strong>To: </strong>niccolove, VDG, ngraham<br /><strong>Cc: </strong>mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns<br /></div>