<table><tr><td style="">ndavis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26758">View Revision</a></tr></table><br /><div><div><p>This patch has a few problems and some things to consider.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Changing the size to <tt style="background: #ebebeb; font-size: 13px;">units.iconSizes.small</tt> doesn't seem to break any layouts we have, but I have not done extensive testing with 3rd party widgets.</li>
<li class="remarkup-list-item">Is the size too small for touch input? If yes, that would mean the QStyle needs to be changed too.</li>
<li class="remarkup-list-item">For whatever reason, the checkboxes and radio buttons seem to grow in height and width by maybe 1px when hovered or checked. I can't figure out why and it still causes some pixel alignment issues, particularly with radio buttons.</li>
<li class="remarkup-list-item">Is it desirable to have multiple sizes for checkboxes and radio buttons? If not, then I suppose I should remove every size other than the one we choose from the svgs. Currently, I have 16, 22, 24 and 32px versions in both svgs.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26758">https://phabricator.kde.org/D26758</a></div></div><br /><div><strong>To: </strong>ndavis, Plasma, VDG<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>