<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26407">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26407#inline-151127">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmountpoint.cpp:443</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">parentPath</span> <span style="color: #aa2211">=</span> <span class="n">splitted</span><span class="p">.</span><span class="n">join</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">fileinfo</span> <span style="color: #aa2211">=</span> <span class="n">QFileInfo</span><span class="p">(</span><span class="n">parentPath</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">fileinfo</span><span class="p">.</span><span class="n">isSymLink</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why reuse and assign, compared to just <tt style="background: #ebebeb; font-size: 13px;">const QFileInfo fileinfo(parentPath)</tt>?</p>

<p style="padding: 0; margin: 8px;">(Same for parentPath -- I prefer C++ over C)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26407#inline-151129">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmountpoint.cpp:447</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #74777d">// for /dir/link/dir/test will return result for /destLink/dir/test</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span class="n">findByPath</span><span class="p">(</span><span class="n">fileinfo</span><span class="p">.</span><span class="n">symLinkTarget</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">poped</span><span class="p">.</span><span class="n">join</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wouldn't .mid() be faster than split+join? Just wondering. I see why you need to split, just wondering about join..</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26407#inline-151128">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmountpoint.cpp:449</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">poped</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">splitted</span><span class="p">.</span><span class="n">takeLast</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Doesn't this reverse the order?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26407">https://phabricator.kde.org/D26407</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, ngraham, broulik, dfaure<br /><strong>Cc: </strong>anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>