<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26690">View Revision</a></tr></table><br /><div><div><p>Thanks for looking into this, I'm glad that finally someone does dig into this code.</p>
<p>I'm a bit surprised by the solution though. The spec simply says</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">add any "Default Applications" and then "Added Associations" in the first mimeapps.list</li>
</ul>
<p>This doesn't need any reverse iteration or prepending, it's just about reading Default Applications before Added Associations rather than the other way around, isn't it?</p>
<p>I think my comment 5 years ago also meant that the xdg spec allows for the default app (left-click in file manager) to be different from the preferred app (RMB / Open With).<br />
But looking at the spec now (Application ordering) it really treats "Default Applications" as higher-priority Added Associations, which proves that having separated the two is just complete nonsense, they serve the same purpose. Bleh. At least it's easier to implement this way :-)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26690#inline-150939">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmimeassociations.cpp:112</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span class="n">services</span> <span style="color: #aa2211">=</span> <span class="n">group</span><span class="p">.</span><span class="n">readXdgListEntry</span><span class="p">(</span><span class="n">mimeName</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// since the first has precendence and we prepend entries, we need to reverse the list of service</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">reverse</span><span class="p">(</span><span class="n">services</span><span class="p">.</span><span class="n">begin</span><span class="p">(),</span> <span class="n">services</span><span class="p">.</span><span class="n">end</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">typo: precedence</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26690#inline-150940">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmimeassociations.cpp:113</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// since the first has precendence and we prepend entries, we need to reverse the list of service</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">reverse</span><span class="p">(</span><span class="n">services</span><span class="p">.</span><span class="n">begin</span><span class="p">(),</span> <span class="n">services</span><span class="p">.</span><span class="n">end</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">resolvedMimeName</span> <span style="color: #aa2211">=</span> <span class="n">mimeName</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"x-scheme-handler/"</span><span class="p">))</span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">mimeName</span> <span class="p">:</span> <span class="n">db</span><span class="p">.</span><span class="n">mimeTypeForName</span><span class="p">(</span><span class="n">mimeName</span><span class="p">).</span><span class="n">name</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Iterating with rbegin/rend (instead of the range-for on line 119) would be faster.</p>
<p style="padding: 0; margin: 8px;">Or .... factorize the rest of the loop with the other method, since that's all duplicated otherwise? Then that's a good reason to keep the same range-for.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26690#inline-150941">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmimeassociations.cpp:125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//qDebug() << "prepending mime" << resolvedMimeName << "to service" << pService->entryPath() << "pref=" << pref;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_offerHash</span><span class="p">.</span><span class="n">prependServiceOffer</span><span class="p">(</span><span class="n">resolvedMimeName</span><span class="p">,</span> <span class="n">KServiceOffer</span><span class="p">(</span><span class="n">pService</span><span class="p">,</span> <span class="n">pref</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">pService</span><span style="color: #aa2211">-></span><span class="n">allowAsDefault</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">--</span><span class="n">pref</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Replace the last argument with true, clearly this service is allowed as default :)<br />
(I'll remove allowAsDefault in KF6 anyway)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26690#inline-150942">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kmimeassociations.cpp:200</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">KOfferHash</span><span style="color: #aa2211">::</span><span class="n">prependServiceOffer</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">serviceType</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">KServiceOffer</span> <span style="color: #aa2211">&</span><span class="n">offer</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I must be tired, but I don't see any difference between the code of this method and the one in addServiceOffer?</p>
<p style="padding: 0; margin: 8px;">(and depending on what the difference should be, I think this should be a single method with an enum argument, to reduce duplication)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R309 KService</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26690">https://phabricator.kde.org/D26690</a></div></div><br /><div><strong>To: </strong>meven, dfaure, dvratil, ervin, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>