<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26043">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26043#inline-149707">View Inline</a><span style="color: #4b4d51; font-weight: bold;">containmentinterface.cpp:1129</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_containment</span><span style="color: #aa2211">-></span><span class="n">containmentType</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">DesktopContainment</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">desktopMenu</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">m_containment</span><span style="color: #aa2211">-></span><span class="n">corona</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">actions</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">action</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"edit mode"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would prefer to see:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">auto action = m_containment->corona()->actions()->action(QStringLiteral("edit mode"));
if (action) {
        desktopMenu->addAction(action);
}</pre></div>

<p style="padding: 0; margin: 8px;">As otherwise we're relying on things which aren't specific public API. It's the sort of thing that can easily change in an updated library release and then our old software starts crashing.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26043">https://phabricator.kde.org/D26043</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, mart, ngraham, davidedmundson<br /><strong>Cc: </strong>davidedmundson, ngraham, broulik, mart, VDG, kde-frameworks-devel, Plasma, LeGast00n, GB_2, michaelh, bruns<br /></div>