<table><tr><td style="">dfaure accepted this revision.<br />dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26191">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26191#inline-148445">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kio_sftp.cpp:1478</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">sftpProtocol</span><span style="color: #aa2211">::</span><span class="n">truncate</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">filesize_t</span> <span class="n">length</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qCDebug</span><span class="p">(</span><span class="n">KIO_SFTP_LOG</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"truncate, length = "</span> <span style="color: #aa2211"><<</span> <span class="n">length</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">[minor: qDebug already appends spaces between arguments, so you get two here after the '=']</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26191#inline-148446">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kio_sftp.cpp:1497</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">errorCode</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">errorCode</span> <span style="color: #aa2211">=</span> <span class="n">errorCode</span> <span style="color: #aa2211">==</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">ERR_INTERNAL</span> <span style="color: #aa2211">?</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span style="color: #a0a000">ERR_CANNOT_TRUNCATE</span> <span class="p">:</span> <span class="n">errorCode</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">error</span><span class="p">(</span><span class="n">errorCode</span><span class="p">,</span> <span class="n">mOpenUrl</span><span class="p">.</span><span class="n">path</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">self-assignment in some cases is a weird thing to do.<br />
Why not if (errorCode==..) { errorCode = ..; } ?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26191">https://phabricator.kde.org/D26191</a></div></div><br /><div><strong>To: </strong>feverfew, sitter, dfaure, fvogt<br /><strong>Cc: </strong>kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov<br /></div>