<table><tr><td style="">kfunk created this revision.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />kfunk requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26364">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Old version of the code:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">ms = qMax<int>(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1);</pre></div>
<p>... will mean the sleep is for as long as the timer has run *minus* the<br />
intended duration, so if nextTimeoutMsecs is ever set and the timer just<br />
started this becomes very negative, and 1ms is the result.</p>
<p>Inverting the subtraction:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">ms = qMax<int>(d->nextTimeoutMsecs - d->nextTimeout.elapsed(), 1);</pre></div>
<p>Means sleeping for the remaining time, and so far my CPU seems much<br />
happier, with my KIO-HTTP using apps looking fine.</p>
<p>BUG: 392768</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26364">https://phabricator.kde.org/D26364</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/core/slavebase.cpp</div></div></div><br /><div><strong>To: </strong>kfunk<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>