<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19338">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19338#inline-147861">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">where</span> <span class="n">KNewStuffCore</span> <span class="n">expects</span> <span class="n">it</span> <span class="n">to</span> <span class="n">be</span> <span class="n">found</span><span class="p">.</span> <span class="n">Do</span> <span style="color: #aa4000">this</span> <span class="n">by</span> <span class="n">using</span> <span class="n">the</span> <span class="n">CMake</span> <span class="n">variable</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KDE_INSTALL_KNSRCDIR</span> <span style="color: #aa4000">as</span> <span class="n">provided</span> <span class="n">by</span> <span class="n">the</span> <span class="n">KNewStuffCore</span> <span style="color: #aa4000">module</span><span class="p">.</span> <span class="n">You</span> <span class="n">can</span> <span class="n">also</span> <span class="n">handle</span> <span style="color: #aa4000">this</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">yourself</span><span class="p">,</span> <span class="n">which</span> <span class="n">means</span> <span class="n">you</span> <span class="n">will</span> <span class="n">need</span> <span class="n">to</span> <span class="n">feed</span> <span class="n">Engine</span><span class="p">::</span><span class="n">init</span><span class="p">()</span> <span class="n">the</span> <span class="n">full</span> <span class="n">path</span> <span class="n">to</span> <span class="n">the</span> <span class="n">knsrc</span> <span class="n">file</span><span class="p">.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Misses to note which version this variable was introduced, and what to do to support older versions still.</p>

<p style="padding: 0; margin: 8px;">See <a href="https://phabricator.kde.org/D26248" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D26248</a> as proposal to fix this.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19338">https://phabricator.kde.org/D19338</a></div></div><br /><div><strong>To: </strong>leinir, KNewStuff, apol, ngraham, fvogt<br /><strong>Cc: </strong>kossebau, kde-frameworks-devel, KNewStuff, LeGast00n, GB_2, michaelh, ZrenBot, ngraham, bruns<br /></div>