<table><tr><td style="">ahmadsamir updated this revision to Diff 72266.<br />ahmadsamir edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-dad7ppdbqc5xi7r/">(Show Details)</a><br />ahmadsamir added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26236">View Revision</a></tr></table><br /><div><div><p>Address comments</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">First pass.<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />

<br />

Remove a TODO as it has been implemented with KShortUriFilter::configure()<br />

(from dfaure, c.f. review).</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D26236?vs=72213&id=72266">https://phabricator.kde.org/D26236?vs=72213&id=72266</a></div></div><br /><div><strong>BRANCH</strong><div><div>l-qregularexpression (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26236">https://phabricator.kde.org/D26236</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kurifiltertest.cpp<br />

src/core/kprotocolmanager.cpp<br />

src/core/krecentdocument.cpp<br />

src/ioslaves/help/kio_help.cpp<br />

src/ioslaves/http/http.cpp<br />

src/ioslaves/http/kcookiejar/kcookiejar.cpp<br />

src/kpac/script.cpp<br />

src/urifilters/localdomain/localdomainurifilter.cpp<br />

src/urifilters/localdomain/localdomainurifilter.h<br />

src/urifilters/shorturi/kshorturifilter.cpp<br />

src/urifilters/shorturi/kshorturifilter.h<br />

src/widgets/jobuidelegate.cpp<br />

src/widgets/kurlcompletion.cpp<br />

src/widgets/previewjob.cpp</div></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, apol<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>