<table><tr><td style="">dfaure accepted this revision.<br />dfaure added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26236">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26236#inline-147720">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kshorturifilter.cpp:437</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #74777d">// <span class="bright">specific </span>URLs using Qt's <span class="bright">regexp</span> class. This is hard-coded for now.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// URLs using Qt's <span class="bright">QRegularExpression</span> class. This is hard-coded for now.</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// TODO: Make configurable at some point...</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">URLHint</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">hint</span> <span class="p">:</span> <span class="n">qAsConst</span><span class="p">(</span><span class="n">m_urlHints</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">(before I forget: this todo should be removed, <tt style="background: #ebebeb; font-size: 13px;">KShortUriFilter::configure()</tt> does exactly that)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26236#inline-147719">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kshorturifilter.h:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">URLHint</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">r</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">p</span><span class="p">,</span> <span class="n">KUriFilterData</span><span style="color: #aa2211">::</span><span class="n">UriTypes</span> <span class="n">t</span> <span style="color: #aa2211">=</span> <span class="n">KUriFilterData</span><span style="color: #aa2211">::</span><span class="n">NetProtocol</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa2211">:</span> <span class="bright"></span><span class="n"><span class="bright">regexp</span></span><span class="p">(</span><span class="n">QReg<span class="bright">Exp</span></span><span class="p">(</span><span class="n">r</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa2211">:</span> <span class="bright"></span><span class="n"><span class="bright">hintRe</span></span><span class="p">(</span><span class="n">QReg<span class="bright">ularExpression</span></span><span class="p">(</span><span class="n">r</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">,</span> <span class="n">prepend</span><span class="p">(</span><span class="n">p</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">(pre-existing) <tt style="background: #ebebeb; font-size: 13px;">hintRe(r)</tt> would be enough</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>l-qregularexpression (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26236">https://phabricator.kde.org/D26236</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, apol<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>