<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26171">View Revision</a></tr></table><br /><div><div><p>Cool, I like viewporter.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26171#inline-147354">View Inline</a><span style="color: #4b4d51; font-weight: bold;">surface_interface.cpp:464</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sizeChanged</span> <span style="color: #aa2211">|=</span> <span class="p">(</span><span style="color: #aa4000">bool</span><span class="p">)</span><span class="n">buffer</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">C-style casts are frowned upon.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26171#inline-147351">View Inline</a><span style="color: #4b4d51; font-weight: bold;">surface_interface.cpp:485</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">QRectF</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(),</span> <span class="n">bufferSize</span><span class="p">).</span><span class="n">contains</span><span class="p">(</span><span class="n">source</span><span style="color: #aa2211">-></span><span class="n">sourceRectangle</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">wl_resource_post_error</span><span class="p">(</span><span class="n">viewport</span><span style="color: #aa2211">-></span><span class="n">parentResource</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">WP_VIEWPORT_ERROR_OUT_OF_BUFFER</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We're not testing this error in the case of:</p>
<p style="padding: 0; margin: 8px;">buffer is set<br />
viewporter.sourceRect is set</p>
<p style="padding: 0; margin: 8px;">then later<br />
buffer changes<br />
viewporter.sourceRect remains the same</p>
<p style="padding: 0; margin: 8px;">this should be an error too.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26171#inline-147353">View Inline</a><span style="color: #4b4d51; font-weight: bold;">surface_interface.cpp:882</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">current</span><span class="p">.</span><span class="n">sourceRectangle</span><span class="p">.</span><span class="n">isValid</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">current</span><span class="p">.</span><span class="n">sourceRectangle</span><span class="p">.</span><span class="n">size</span><span class="p">().</span><span class="n">toSize</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Should this be</p>
<p style="padding: 0; margin: 8px;">d->current.sourceRectangle.size()/ scale()</p>
<p style="padding: 0; margin: 8px;">It would be a somewhat weird case to use both viewporter and wl_buffer.scale, but it's what the spec implies and you seem to be assuming that in the kwin render path.</p>
<p style="padding: 0; margin: 8px;">destinationSize would be as-is.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26171#inline-147323">View Inline</a><span style="color: #4b4d51; font-weight: bold;">romangg</span> wrote in <span style="color: #4b4d51; font-weight: bold;">surface_interface.h:130</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Needed for a call in a const function in KWin. Do we want to do it like that? Other suggestions?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not just</p>
<p style="padding: 0; margin: 8px;">BufferInterface *buffer() const</p>
<p style="padding: 0; margin: 8px;">There's no reason why a caller would need to explicitly pick a const vs non-const version.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26171">https://phabricator.kde.org/D26171</a></div></div><br /><div><strong>To: </strong>romangg, KWin<br /><strong>Cc: </strong>davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>