<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26123">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26123#inline-147150">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kemailaddresstest.cpp:345</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QFETCH</span><span class="p">(</span><span style="color: #aa4000">bool</span><span class="p">,</span> <span class="n">expResult</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">isValidSimpleAddress</span><span class="p">(</span><span class="n">input</span><span class="p">),</span> <span class="n">expResult</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated and the empty line made sense, please revert</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26123#inline-147155">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kemailaddress.cpp:631</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// to match the whole subject string</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">addrRx</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">A"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Message from Giuseppe D'Angelo (author of QRegularExpression) : if you can depend from Qt 5.12, there's QRegularExpression::anchoredPattern instead of manual wrapping in \A and \z</p>
<p style="padding: 0; margin: 8px;">We can't require 5.12 yet but this could be a TODO to simplify this code slightly at some point.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26123#inline-147156">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kemailaddress.cpp:639</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">domainPart</span><span class="p">[</span> <span style="color: #601200">0</span> <span class="p">]</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">'['</span><span class="p">)</span> <span style="color: #aa2211">||</span> <span class="n">domainPart</span><span class="p">[</span> <span class="n">domainPart</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span> <span class="p">]</span> <span style="color: #aa2211">==</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">']'</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">addrRx</span> <span style="color: #aa2211">+=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">[[0-9]{<span class="bright">,3}(</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">.</span>[0-9]{,3})<span class="bright">{3}</span></span><span style="color: #bb6622">\\</span><span style="color: #766510">]"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">addrRx</span> <span style="color: #aa2211">+=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\\</span><span style="color: #766510">[<span class="bright">(</span>[0-9]{<span class="bright">1,3}</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">.){1,3}(</span>[0-9]{<span class="bright">1</span>,3})</span><span style="color: #bb6622">\\</span><span style="color: #766510">]"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">{,3}</tt> would be <tt style="background: #ebebeb; font-size: 13px;">{0,3}</tt>, not <tt style="background: #ebebeb; font-size: 13px;">{1,3}</tt></p>
<p style="padding: 0; margin: 8px;">Would this allow to minimize the amount of changes made here? I'm worried about regressions.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26123#inline-147157">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kemailaddress.cpp:1119</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QReg<span class="bright">Exp</span></span> <span style="color: #004012">needQuotes</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"[^ 0-9A-Za-z</span><span style="color: #bb6622">\\</span><span style="color: #766510">x0080-</span><span style="color: #bb6622">\\</span><span style="color: #766510">xFFFF]"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QReg<span class="bright">ularExpression</span></span> <span style="color: #004012">needQuotes</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"[^ 0-9A-Za-z</span><span style="color: #bb6622">\\</span><span style="color: #766510">x0080-</span><span style="color: #bb6622">\\</span><span style="color: #766510">xFFFF]"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// avoid double quoting</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Also from Giuseppe : the <tt style="background: #ebebeb; font-size: 13px;">\\x0080-\\xFFFF</tt> requires changes to <tt style="background: #ebebeb; font-size: 13px;">\\x{0080}-\\x{FFFF}</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R270 KCodecs</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26123">https://phabricator.kde.org/D26123</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, mlaurent, vkrause<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>