<table><tr><td style="">ndavis requested changes to this revision.<br />ndavis added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25815">View Revision</a></tr></table><br /><div><div><p>Hey, thanks for the patch!</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Breeze usually uses 1px lines, but does use 2px in some instances (mainly centered lines). You can use a 2px thickness at the bottom in this case to match the look of the original logo.</li>
<li class="remarkup-list-item">The shapes need to be aligned to 1px grid spaces. If using strokes, use miter joins (value: 4), square caps, align to the centers of pixels and then convert to paths. I won't be too picky about diagonal lines except for 45 degree angles: <a href="https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Diagonal_lines" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Diagonal_lines</a></li>
<li class="remarkup-list-item">The margins must to be 3px on the top and bottom, but you can fudge the horizontal margins as needed</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25815">https://phabricator.kde.org/D25815</a></div></div><br /><div><strong>To: </strong>vinzenzv, VDG, ndavis<br /><strong>Cc: </strong>ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, michaelh, bruns<br /></div>