<table><tr><td style="">ndavis edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-pr3lfxmdzz2brp5/">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25676">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">I noticed that QPalette had these (see link below), but KColorScheme didn't. Since there is no function to get the number of items in an enum for C++, it seems like it would be useful to have a built-in way to get the total number of color sets or roles. <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">I will make a follow up patch to reduce the amount of hardcoded values in KColorScheme</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">For instance, a person might want to create an array of all foreground colors, but they would have to hardcode the values without this patch</span>.<div style="padding: 8px 0;">...</div>https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/kernel/qpalette.h#n90<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
<br />
I plan to make a follow up patch to reduce the amount of hardcoded values in KColorScheme.</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R265 KConfigWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25676">https://phabricator.kde.org/D25676</a></div></div><br /><div><strong>To: </strong>ndavis, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>