<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23384">View Revision</a></tr></table><br /><div><div><p>I tested this today with a variety of files on a Windows Samba share with fairly slow 6 Mb/sec bandwidth and it's almost perfect for all files and use cases. However I ran into some issues with handling large video files on a Samba share. This is an important use case and supports the workflow of viewing or working on video files stored on a NAS or media PC. I tried opening a large-ish 800 Mb video file using VLC, Totem (a.k.a. GNOME Videos), and SMPlayer. Here are the results:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">VLC receives a <tt style="background: #ebebeb; font-size: 13px;">smb://</tt> URL and failes to open the file, displaying the following error message:<a href="https://phabricator.kde.org/F7790278" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7790278: Screenshot_20191129_141256.png</a></li>
<li class="remarkup-list-item">Totem launches immediately but displays nothing. Network traffic indicates that it is locally downloading the entire file to a cache somewhere. Once the network traffic ends, it begins playing the file.</li>
<li class="remarkup-list-item">SMPlayer receives a <tt style="background: #ebebeb; font-size: 13px;">smb://</tt> URL and fails to open the file, displaying the following error message:<a href="https://phabricator.kde.org/F7790279" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7790279: Screenshot_20191129_141354.png</a></li>
</ul>
<h2 class="remarkup-header">Issue #1</h2>
<p>It looks like both VLC and SMPlayer are getting the <tt style="background: #ebebeb; font-size: 13px;">smb://</tt> URL and failing to open it because they don't already have credentials for the share, which is stupid and probably their own faults for not at least prompting the user for it (VLC used to do this on other distros I've used, so that may be a regression in the app, or a packaging issue on openSUSE). But neither app uses KIO, so they should be getting the path to the FUSE mount instead.</p>
<h2 class="remarkup-header">Issue #2</h2>
<p>Even when opening the file directly from the hidden KIO-FUSE mount, all tested apps download the file locally instead of just reading it and starting playback. When I use Nautilus to mount the same samba share and open the file in Totem, the app opens and playback begins almost instantly. So it looks like the entire file does not have to be downloaded first with the GNOME FUSE implementation, but something in our implementation is causing this to happen compared to theirs.</p>
<p>This can be confirmed by navigating to the hidden FUSE mount paths generated by KIO-FUSE and GVFS.</p>
<p><tt style="background: #ebebeb; font-size: 13px;">totem /run/user/1000/gvfs/smb-share\:server\=living-room-pc\,share\=users\,user\=gaston/Gaston/Desktop/Starship\ Troopers.avi</tt> - Totem opens instantly and playback begins instantly</p>
<p><tt style="background: #ebebeb; font-size: 13px;">totem '/run/user/1000/kio-fuse-vCERHW/smb/gaston@living-room-pc/Users/Gaston/Desktop/Starship Troopers.avi'</tt> - Totem opens instantly but downloads the entire file locally before starting playback</p>
<p>The same behavior happens when using VLC or SMPlayer instead of Totem. So it seems like there is some issue with our KIO-FUSE mount that causes the app to not understand that it can skip the lengthy download. Or maybe KIO itself is still doing this, even though it's no longer necessary. Or maybe Totem, VLC, and SMPlayer have special logic to invoke the more desirable "play instantly" behavior for URLs opened with GVFS paths and will need to be patched to invoke the same behavior for our KIO-FUSE paths as well.</p>
<h2 class="remarkup-header">Issue #3</h2>
<p>I feel like Dolphin should not hang when you open a large file from the FUSE mount path directly and a long download begins. This should happen in another process or thread so that Dolphin's main UI isn't blocked.</p>
<hr class="remarkup-hr" />
<p>Some of these issues may be out of scope for this patch but I thought I'd just put them here in this review, and we can figure out if they need to be addressed elsewhere.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23384">https://phabricator.kde.org/D23384</a></div></div><br /><div><strong>To: </strong>feverfew, fvogt, davidedmundson, dfaure, ngraham<br /><strong>Cc: </strong>sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns<br /></div>