<table><tr><td style="">davidedmundson added subscribers: ndavis, davidedmundson.<br />davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25590">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25590#inline-144406">View Inline</a><span style="color: #4b4d51; font-weight: bold;">colorscope.cpp:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">QQuickItem</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="n">parent<span class="bright">Item</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">QQuickItem</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">parentObject</span><span class="p">)<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p">(</span><span class="n">parentItem<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">parent<span class="bright">Object</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">QQuickItem</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">parentObject</span><span class="p">)<span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n"><span class="bright">connect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">QQuickItem</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*></span></span><span class="p">(</span><span class="n">parent<span class="bright">Object</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">QQuick</span>Item<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">parentChanged</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It' be better to split this colour change stuff.</p>
<p style="padding: 0; margin: 8px;">It's effectively an unrelated bugfix/cleanup</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25590#inline-144398">View Inline</a><span style="color: #4b4d51; font-weight: bold;">colorscope.cpp:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="p"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Make sure QppletInterface always has a ColorScope</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">s</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">ColorScope</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">qmlAttachedPropertiesObject</span><span style="color: #aa2211"><</span><span class="n">ColorScope</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">candidate</span><span class="p">,</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">PlasmaQuick</span><span style="color: #aa2211">::</span><span class="n">AppletQuickItem</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">candidate</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">typo</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25590#inline-144396">View Inline</a><span style="color: #4b4d51; font-weight: bold;">configuration-icons.svg:17</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> version="1.1"
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> inkscape:version="0.<span class="bright">48.5 r10040</span>"
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> sodipodi:docname="configuration-icons.svg<span class="bright">z</span>">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> inkscape:version="0.<span class="bright">92.2 5c3e80d, 2017-08-06</span>"
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> sodipodi:docname="configuration-icons.svg">
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a> can you review this icon change please</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25590#inline-144399">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasma.h:284</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ShadowBackground</span> <span style="color: #aa2211">=</span> <span style="color: #601200">4</span><span class="p">,</span> <span style="color: #74777d">/**< The applet won't have a svg background but a drop shadow of its content done via a shader */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ImmutableBackground</span> <span style="color: #aa2211">=</span> <span style="color: #601200">8</span><span class="p">,</span> <span style="color: #74777d">/** The user shouldn't have the possibility to */</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">DefaultBackground</span> <span style="color: #aa2211">=</span> <span class="n">StandardBackground</span> <span style="color: #74777d">/**< Default settings: both standard background */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the user shouldn't have the possibility to.....</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25590#inline-144405">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appletinterface.cpp:201-202</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">value</span> <span style="color: #aa2211">=</span> <span class="n">hintEnum</span><span class="p">.</span><span class="n">keyToValue</span><span class="p">(</span><span class="n">hintsString</span><span class="p">.</span><span class="n">constData</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">value</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_effectiveBackgroundHints</span> <span style="color: #aa2211">=</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">BackgroundHints</span><span class="p">(</span><span class="n">value</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_effectiveBackgroundHintsInitialized</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">0 == NoBackground which is a perfectly valid entry</p>
<p style="padding: 0; margin: 8px;">I think we need to use the<br />
keyToValue(QString, bool*) overload and check the return value.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25590">https://phabricator.kde.org/D25590</a></div></div><br /><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>