<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: leinir, Plasma, Frameworks.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25585">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Using <tt style="background: #ebebeb; font-size: 13px;">.arg()</tt> in <tt style="background: #ebebeb; font-size: 13px;">i18n()</tt> calls can lead to runtime errors such as the ones shown in<br />
<a href="https://bugs.kde.org/show_bug.cgi?id=414498" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=414498</a>. Let's port away from that.</p>

<p>BUG: 414498</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>QML GHNS dialog no longer has any i18n errors in strings</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-i18n-usage (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25585">https://phabricator.kde.org/D25585</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/attica/atticaprovider.cpp<br />
src/qtquick/qml/Dialog.qml<br />
src/qtquick/qml/EntryDetails.qml<br />
src/qtquick/qml/private/EntryCommentDelegate.qml<br />
src/qtquick/qml/private/EntryCommentsPage.qml<br />
src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml<br />
src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml<br />
src/qtquick/quickitemsmodel.cpp</div></div></div><br /><div><strong>To: </strong>ngraham, leinir, Plasma, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>