<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25545">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25545#inline-144303">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Doxyfile.local:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"># define so that deprecated API is not skipped
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">PREDEFINED += \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> "KCOREADDONS_ENABLE_DEPRECATED_SINCE(x, y)=1" \
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The predefined macros we want to tell doxygen about in the case of kapidox (being run in a non-build checkout, so without the generated headers/sources) are both the variants of the 3 macros for SONNETCORE and SONNETUI, not KCOREADDONS :)</p>
<p style="padding: 0; margin: 8px;">In case you wonder about the differences for instructions to ecm_add_qch, kapidox processes the whole sources with both libs into one documentation module, while the ecm macro is used to create two separate QCH files, one per library.<br />
(and ecm_add_qch also is run in a build, so with the generated headers/sources available, cmp. also the INCLUDE_DIRS arg. Sadly doxygen does not digest the <tt style="background: #ebebeb; font-size: 13px;">__deprecated(text)__</tt> attribute properly, so we need to help it with the very warning deprecation macro (*_DEPRECATED_VERSION) and have it resolve it itself to a void string instead of the real content. At least the *_DEPRECATED_SINCE are properly done, so no assistance needed there)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25545#inline-144304">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> DEPRECATED_BASE_VERSION 0
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> DEPRECATION_VERSIONS 5.65
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT}
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Given there is nothing yet deprecated in the core lib, you want for now to not pass any DEPRECATION_VERSIONS args (to avoid the respective generated preprocessor code).<br />
You can still prepare the argument by just making the line a comment, like</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"># DEPRECATION_VERSIONS 5.x</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25545#inline-144305">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dialog.h:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * The dialog won't be closed if you setBuffer() in slot connected to this signal</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @Since 5.65</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * Also emitted after stop() signal</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The <span class="phabricator-remarkup-mention-unknown">@since</span> would ideally also be move to the end of the docs.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R246 Sonnet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25545">https://phabricator.kde.org/D25545</a></div></div><br /><div><strong>To: </strong>mlaurent, dfaure, kossebau<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>