<table><tr><td style="">waqar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25530">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Sorry but i don't think this is an acceptable solution,</p></blockquote>
<p>With all due respect, the end user doesn't give a crap whether it was a problem in QLocale, or whether it needed to be done in many places in KDE code and that nobody did it. The end user opens the menu, sees 'American English (United States)' and below that 'cv_RU' and he is just going to think the developers didn't fix it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>there's lots of other places in KDE code we use QLocale to get the name of a language, if you do this here you'll have to do the same in like 5 places.</p></blockquote>
<p>Alright lets do it in all the places. I will do it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Instead just fix it in the proper place</p></blockquote>
<p>What would be the proper place? Qt Code? I am not sure about that. Maybe this doesn't happen on other operating systems. Maybe it's an OS issue.(I don't have other operating systems to test on) Even if it is in Qt Code, improving Qt is great and beneficial for everyone, but its gonna take some time, 6 months? maybe more. In the meantime, this may not be the cleanest and the best solution but it is something and something is better than nothing.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R246 Sonnet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25530">https://phabricator.kde.org/D25530</a></div></div><br /><div><strong>To: </strong>waqar<br /><strong>Cc: </strong>aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>