<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25545">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25545#568090" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25545#568090</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Looks good to me. Friedrich, what did we conclude about deprecating signals?</p></div>
</blockquote>
<p>From <a href="https://phabricator.kde.org/D24466#547023" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D24466#547023</a> & ff. I took with me that deprecating signals like methods should be fine, and will work WRT visibility and warnings at least with member-function-pointer-based connects.</p>
<p>For the rest looks good also to me. Happy to see that ecm_generate_export_header usage can be applied as intended by somebody else than me :)</p>
<p>Though one thing (which I also only fixed in later commits) is missing: instructing KApiDox & ecm_add_qch about the new deprecation macros (they need some help sadly). Cmp. e.g.<br />
<a href="https://phabricator.kde.org/R244:344565e7f6c6782b287d73373e7ce2319c80eab2" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">R244:344565e7f6c6782b287d73373e7ce2319c80eab2</a> for kcoreaddons, and see also <a href="https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25545#inline-144260">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dialog.h:102</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * The dialog won't be closed if you setBuffer() in slot connected to this signal</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> *</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *<span class="bright"> @deprecated Since 5.65, use spellCheckDone</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * Also emitted after stop() signal</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><span class="phabricator-remarkup-mention-unknown">@deprecated</span> Should be last in docs text,<br />
Cmp. also <a href="https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R246 Sonnet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25545">https://phabricator.kde.org/D25545</a></div></div><br /><div><strong>To: </strong>mlaurent, dfaure, kossebau<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>