<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24349">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24349#inline-144240">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfileplacesmodel.cpp:280</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KFilePlacesItem</span><span style="color: #aa2211">::</span><span class="n">createSystemBookmark</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">bookmarkManager</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">I18NC_NOOP</span><span class="p">(</span><span style="color: #766510">"KFile System Bookmarks"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510">"Home"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">I18NC_NOOP</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"KFile System Bookmarks"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"Home"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromLocalFile</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">()),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"user-home"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The QStringLiteral here might create trouble for the translation extraction scripts?</p>
<p style="padding: 0; margin: 8px;">I think the proper fix is to change the signature of createSystemBookmark to take two QByteArray arguments. Or you could even keep const char* for the context (the first one of the two) since it's dropped, no point in creating a QByteArray out of it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24349#inline-144241">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpasswdservertest.cpp:325</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">AuthInfo</span> <span class="n">info</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">info</span><span class="p">.</span><span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span class="p">(</span><span style="color: #766510">"http://www.example.com/test"</span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">i</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #766510">".html"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">info</span><span class="p">.</span><span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"http://www.example.com/test"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">i</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">".html"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">authInfos</span> <span style="color: #aa2211"><<</span> <span class="n">info</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">[same as above]</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24349">https://phabricator.kde.org/D24349</a></div></div><br /><div><strong>To: </strong>ahmadsamir, dfaure, Frameworks<br /><strong>Cc: </strong>yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>